This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Added call to connect/site-info in BlogServiceRemote #90
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
related issue: wordpress-mobile/WordPressAuthenticator-iOS#52 Purpose: Getting site info without authentication.
related issue: wordpress-mobile/WordPressAuthenticator-iOS#52 Purpose: Getting site info without authentication.
…ordpress-mobile/WordPressKit-iOS into fix/52-login_with_private_site
aerych
suggested changes
Feb 14, 2019
Contributor
aerych
left a comment
aerych
left a comment
There was a problem hiding this comment.
Heya Yael!
Just two small requests then it should be good to go!
Contributor
Author
|
@aerych , thanks for this review. I didn't want to touch the code in fetchSiteInfo. Updated according to your review |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related issue: wordpress-mobile/WordPressAuthenticator-iOS#52
Purpose: Getting site info without authentication.
Description
Fixes wordpress-mobile/WordPressAuthenticator-iOS#52