This repository was archived by the owner on Sep 15, 2025. It is now read-only.
Stats: Add support for fetching top posts #98
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ScoutHarris
approved these changes
Feb 21, 2019
Contributor
ScoutHarris
left a comment
ScoutHarris
left a comment
There was a problem hiding this comment.
Hey @jklausa . Just one query/possible change. Otherwise looks good!
|
|
||
| static func kind(from kindString: String?) -> Kind { | ||
| switch kindString { | ||
| case "post"?: |
Contributor
There was a problem hiding this comment.
Are these ? necessary? I removed them and the tests passed. Seems like they're not needed...
Contributor
Author
There was a problem hiding this comment.
Huh, thanks for that — I would have sworn I tried before and it failed to build before!
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Last set of those! I'll be posting few more PRs today, but that should be it.
Let's start with top posts :)!
Testing Details