This repository was archived by the owner on Jun 4, 2025. It is now read-only.
Allow BottomSheetViewController to work as a modal #126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By allowing the `BottomSheetViewController` to forward the `allowsTapToDismiss` and `allowsDragToDismiss` properties to its child, we allow consumers to gain extra functionality, for example, to make the bottom sheet non-dismissable.
1 task
rachelmcr
approved these changes
May 25, 2023
Contributor
Author
|
Hi @mokagio, are you the one in charge of creating a new stable release? From the instructions(paNNhX-33-p2) is not clear if the release manager is the one in charge to release a new stable build. TIA |
Merged
1 task
Contributor
|
@Ecarrion hey mate 👋 Anyone can ship a new build, but apps infrastructure are usually the most suited to do this because of some implicit / undocumented knowledge in the process. I'll drop a note in the post, but really what we should do is invest in more automation. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why
This PR updates the
BottomSheetViewControllertype to forward theallowsTapToDismissandallowsDragToDismissproperties to its child.This is useful, for cases where we want the bottom sheet to be un-dismissable when we want it to behave as a modal.
CHANGELOG.mdif necessary.