This repository was archived by the owner on Jun 4, 2025. It is now read-only.
Auto Layout helpers: add insets to edge pinning and safe area with insets #39
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Aug 12, 2019
Contributor
2 tasks
mindgraffiti
approved these changes
Aug 14, 2019
Contributor
mindgraffiti
left a comment
mindgraffiti
left a comment
There was a problem hiding this comment.
Confirmed it works for WCiOS.
frosty
approved these changes
Aug 14, 2019
Contributor
frosty
left a comment
frosty
left a comment
There was a problem hiding this comment.
Sorry for the delay reviewing! Looks great, thanks for doing this! Don't forget to do a new release of the pod :)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing
WordPressUIpod to Auto Layout changes PR branch WordPress-iOS#12293WordPressUIpod to Auto Layout changes PR branch woocommerce/woocommerce-ios#1170Changes
insets: UIEdgeInsetsparameter topinSubviewToAllEdges(_ subview: UIView), and called this new function with zero insets inpinSubviewToAllEdges(_ subview: UIView)insetsparameter is necessary for Objective-C compatibility, otherwise we can set the default parameter of zero insets in the same functionpinSubviewToSafeArea(_ subview: UIView, insets: UIEdgeInsets)andpinSubviewToSafeArea(_ subview: UIView)with zero insets