Skip to content

DataViews density option: preserve selection across layout selection #76380

@andrewserong

Description

@andrewserong

Follow-up to:

Review feedback on the above PR noted that now that each layout type has a density option, selecting a density option should be preserved as a user switches between layout types. This is the control:

Image

From the comments (#75887 (comment)):

The way I envision this is that we just make density part of the ViewBase type. The edge case we need to check is what happens when there's a stored view (e.g., user has saved some changes) and we introduce this change.

I think another thing to double-check is:

  • If an instance of the DataViews defines its own value for density and a user has made no selection, the value defined by that DataViews instance should take priority
  • For that particular DataViews instance (e.g. media library modal, etc), if a user has made a selection (or preserved preference), then that preference takes precedence over the value provided by that view

Metadata

Metadata

Assignees

No one assigned

    Labels

    [Feature] DataViewsWork surrounding upgrading and evolving views in the site editor and beyond[Type] EnhancementA suggestion for improvement.

    Type

    No type
    No fields configured for issues without a type.

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions