Skip to content

Conversation

@shihanpan
Copy link
Collaborator

  • Add type=int to --parent-id to ensure proper conversion from CLI string to integer
  • Add required=True to --external-id since it's not optional in the function signature

Fixes validation errors:

  • parent_id: Input should be a valid integer [type=int_type, input_value='92', input_type=str]
  • external_id: Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]

- Add type=int to --parent-id to ensure proper conversion from CLI string to integer
- Add required=True to --external-id since it's not optional in the function signature

Fixes validation errors:
- parent_id: Input should be a valid integer [type=int_type, input_value='92', input_type=str]
- external_id: Input should be a valid string [type=string_type, input_value=None, input_type=NoneType]

Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
@github-actions
Copy link

Coverage

Coverage Report
FileStmtsMissCoverMissing
__init__.py68494%10–11, 69–70
cli
   __init__.py52394%49, 51, 60
   containers.py270100% 
cli/commands
   __init__.py00100% 
   api_clients.py291996%27, 302, 448–449, 483, 493, 584, 615, 623
   api_collections.py257398%28, 183, 347
   assets.py47295%57–58
   connections.py526599%596, 598, 604, 642, 993
   data_tables.py165596%31, 253, 267, 321–322
   guide.py166199%106
   init.py1070100% 
   profiles.py2310100% 
   properties.py97198%21
   pull.py172298%193–194
   workspace.py39294%61, 71
cli/commands/connectors
   __init__.py00100% 
   command.py90297%110, 159
   connector_manager.py203498%176, 292, 300–301
cli/commands/projects
   __init__.py00100% 
   command.py2721096%359–362, 373, 439–441, 491, 495
   project_manager.py166795%48, 66, 263–264, 276, 317, 325
cli/commands/push
   __init__.py00100% 
   command.py133496%109, 112, 230, 308
cli/commands/recipes
   __init__.py00100% 
   command.py427997%117, 133–134, 272–275, 403, 709
   validator.py7062097%174, 883, 1136, 1223, 1246, 1279, 1281–1282, 1359–1361, 1457–1458, 1517–1518, 1707–1708, 1736–1738
cli/utils
   __init__.py40100% 
   exception_handler.py3453390%134–135, 140–141, 143–144, 174–175, 181, 184–185, 270, 300, 333–337, 371, 398, 425, 482, 517, 576, 578–579, 584–585, 587–591
   gitignore.py140100% 
   ignore_patterns.py230100% 
   spinner.py430100% 
   token_input.py451762%70, 98, 100, 102–104, 107, 124, 127–128, 132–133, 136, 139–140, 142, 144
   version_checker.py135695%24, 26, 33–34, 72, 102
cli/utils/config
   __init__.py50100% 
   manager.py5313393%127, 138, 149, 157–159, 162, 165, 177, 227–228, 399, 417, 421, 424–427, 443, 464, 478, 491, 533, 623–624, 661, 875, 1018–1019, 1033–1034, 1090, 1149
   models.py330100% 
   profiles.py3341595%99, 195–196, 199, 234–236, 261–263, 522, 530, 541–542, 546
   workspace.py680100% 
TOTAL582219796% 

@shihanpan shihanpan requested review from hovu96 and j-madrone January 29, 2026 14:12
@shihanpan shihanpan merged commit 52d2900 into main Jan 29, 2026
9 checks passed
@shihanpan shihanpan deleted the bugfix-connections-create-oauth-validation branch January 29, 2026 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants