Skip to content

Add a page that shows the network's version infos#37

Merged
SvenDowideit merged 1 commit intomainfrom
working-out-how-to-show-node-info
Mar 17, 2022
Merged

Add a page that shows the network's version infos#37
SvenDowideit merged 1 commit intomainfrom
working-out-how-to-show-node-info

Conversation

@SvenDowideit
Copy link
Copy Markdown
Member

@SvenDowideit SvenDowideit commented Mar 8, 2022 •
edited
Loading

I wanted to know what the versions were - took quite a bit of reading to get to where this is - and I don't know if its the right way to make it work, but its a start

image

@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch 3 times, most recently from cd3fdc5 to 37871e9 Compare March 14, 2022 07:52
@SvenDowideit SvenDowideit changed the title [WIP] figuring out how to add a page that shows the network's version infos Add a page that shows the network's version infos Mar 14, 2022
@nathanleclaire
Copy link
Copy Markdown
Contributor

nathanleclaire commented Mar 14, 2022

Nice! This is giving me vibes of having a full blown "Network" page at some point. Showing service map with info about validators region, latency, stake, etc. Since we use faNetworkWired in the net toggle dropdown, I wonder if that icon would be good to use for this subsection of the app.

@nathanleclaire
Copy link
Copy Markdown
Contributor

nathanleclaire commented Mar 14, 2022

So, I do wonder what role this has in a world where https://solanabeach.io/validators exists. Any thoughts?

nathanleclaire
nathanleclaire reviewed Mar 14, 2022
View reviewed changes
Comment thread src/renderer/nav/VersionInfo.tsx Outdated
@SvenDowideit
Copy link
Copy Markdown
Member Author

SvenDowideit commented Mar 15, 2022

So one of the problems I want to solve, is that there's one place to get all the info - atm, its all scattered on different sites, and until you're in the know - and remember what the url is, the new dev has no idea what info is available to them.
Mind you, it would be excellent to not only give the info, but to link to those sites.

@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch from 37871e9 to 27a3b5d Compare March 15, 2022 00:45
@nathanleclaire
Copy link
Copy Markdown
Contributor

nathanleclaire commented Mar 15, 2022

Roger, that checks out

nathanleclaire
nathanleclaire reviewed Mar 15, 2022
View reviewed changes
Comment thread src/main/main.ts Outdated
nathanleclaire
nathanleclaire reviewed Mar 15, 2022
View reviewed changes
Comment thread src/main/versionInfo.ts
@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch from 0918ed1 to c6a8253 Compare March 15, 2022 05:54
nathanleclaire
nathanleclaire requested changes Mar 16, 2022
View reviewed changes
Comment thread src/renderer/nav/VersionInfo.tsx
Comment thread src/renderer/nav/VersionInfo.tsx Outdated
@nathanleclaire
Copy link
Copy Markdown
Contributor

nathanleclaire commented Mar 16, 2022

also needs prettying and there's a few versionInfo still there would like 'em to be validatorVersionInfo

@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch 3 times, most recently from 84c1472 to 725d8ef Compare March 17, 2022 01:08
nathanleclaire
nathanleclaire approved these changes Mar 17, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@nathanleclaire nathanleclaire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! Just a couple final nits and LGTM

Comment thread src/main/validatorNetworkInfo.ts Outdated
Comment thread src/renderer/App.tsx Outdated
@SvenDowideit SvenDowideit force-pushed the working-out-how-to-show-node-info branch from 725d8ef to 95012e0 Compare March 17, 2022 01:42
@SvenDowideit SvenDowideit merged commit c5f8e52 into main Mar 17, 2022
@SvenDowideit SvenDowideit deleted the working-out-how-to-show-node-info branch March 17, 2022 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@nathanleclaire nathanleclaire nathanleclaire approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@SvenDowideit @nathanleclaire