Update network connectivity on selection, and detect if the network becomes reachable/not#44
Conversation
|
The real reason i started looking, is that if you have a local validator, and stop it, after that, the unsubscribeprogramchanges fails hard, and from that point, the web3.js code keeps trying which makes me suspect that if we have intermittent network, we're going to notice the resource leak. this will be dealt with in a different PR - possibly in solana-web3.js? |
|
Nice, I really like the change in validator state to enum. Before we double down on program changes, I think we should do some thinking on if it's the right approach. Lately, for instance, I've been wondering why maybe we don't just work our way through the slots (blocks) and store the relevant info in the DB (which programs/accounts are of interest, etc). Then we wouldn't necessarily have this whole fragile subscription model going. |
d3e38b9 to
f29e4d0
Compare
|
@nathanleclaire yup, but that's totally for a different PR/issue :) |
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
f29e4d0 to
bc471f1
Compare
|
LGTM |
changing networks between working and not-working didn't change the validator.running state, so things didn't match up
it still doesn't notice a state change in the selected network, but at least switching networks means it gets updates,