Skip to content

show the error output from validatorLogs func in lov viewer#98

Merged
SvenDowideit merged 4 commits intomainfrom
improve-exec-error-UX
May 5, 2022
Merged

show the error output from validatorLogs func in lov viewer#98
SvenDowideit merged 4 commits intomainfrom
improve-exec-error-UX

Conversation

@SvenDowideit
Copy link
Copy Markdown
Member

closes #41

@nathanleclaire
Copy link
Copy Markdown
Contributor

side note on this one -- is there a reason you decided to go for console.log instead of logger.error on these error logs?

Comment thread src/main/validator.ts
@nathanleclaire
Copy link
Copy Markdown
Contributor

very nice! appreciate this one as it's been a thorn in my side for ages.

have a couple lint issues build is complaining about, but once those are fixed, lgtm

@SvenDowideit
Copy link
Copy Markdown
Member Author

SvenDowideit commented May 4, 2022

I'm going to claim the console.log thing is because #94 isn't merged yet :) (yeah, and i realise how dumb that is - its 100% why i wanted the same UX on main and renderer)

wrt the throw Error - exceptions are ... for exception cases, not for normal, detected results - and this is not exceptional.

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
… local validator container logs if we're on a different network

Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
Signed-off-by: Sven Dowideit <SvenDowideit@home.org.au>
@nathanleclaire
Copy link
Copy Markdown
Contributor

wrt the throw Error - exceptions are ... for exception cases, not for normal, detected results - and this is not exceptional.

either/or, if it's ok with lint, fine by me, just seem to recall my VSCode complaining about it

@nathanleclaire
Copy link
Copy Markdown
Contributor

nathanleclaire commented May 4, 2022

now that #94 is in business, lgtm

@SvenDowideit
Copy link
Copy Markdown
Member Author

yeah, that linter error was weird - mixing return string and return { output } - for now i'm going with just returning a string, and showing that in the UI - atm some point, I hope to upgrade the ipc code to something typed - that thunking makes me cringe like its 1996

@SvenDowideit SvenDowideit merged commit 8add1a8 into main May 5, 2022
@SvenDowideit SvenDowideit deleted the improve-exec-error-UX branch May 5, 2022 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Need to display error when Docker is not detected

2 participants