-
-
Notifications
You must be signed in to change notification settings - Fork 90
Library: Add Banner Entry #243
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Submodule blueprint-compiler
updated
from 402677 to 87a8ef
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,46 @@ | ||
| using Gtk 4.0; | ||
| using Adw 1; | ||
|
|
||
| Gtk.Window window { | ||
| default-width: 800; | ||
| default-height: 600; | ||
| title: "Banner"; | ||
| titlebar: Gtk.HeaderBar { | ||
| [end] | ||
| MenuButton button_menu { | ||
| icon-name: "open-menu-symbolic"; | ||
| primary: true; | ||
| } | ||
| }; | ||
|
|
||
| Adw.ToastOverlay overlay { | ||
| Adw.StatusPage { | ||
| title: "Adw Banner"; | ||
| description: "Gnome Banner Test"; | ||
|
|
||
| Box { | ||
| orientation: vertical; | ||
| halign: center; | ||
| valign: center; | ||
|
|
||
| Adw.Banner banner{ | ||
| button-label: "Troubleshoot"; | ||
| title: "An error occurred: Could not resolve host."; | ||
| revealed: true; | ||
| use-markup: true; | ||
| margin-bottom: 20; | ||
| } | ||
|
Comment on lines
+26
to
+32
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is better, but the banner should really be up at the top of the window, with no margins, right under the header bar. Then maybe make it so clicking "Troubleshoot" hides the banner and shows the toast. Where the banner is now, add a button so the banner can be re-opened. |
||
|
|
||
| LinkButton { | ||
| label: "API Reference"; | ||
| uri: "https://gnome.pages.gitlab.gnome.org/libadwaita/doc/1.3/class.Banner.html"; | ||
| } | ||
|
|
||
| LinkButton { | ||
| label: "Human Interface Guidelines"; | ||
| uri: "https://developer.gnome.org/hig/patterns/feedback/banners.html"; | ||
| } | ||
| } | ||
| } | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| const Adw = imports.gi.Adw; | ||
|
|
||
| const banner = workbench.builder.get_object("banner"); | ||
| const overlay = workbench.builder.get_object("overlay"); | ||
|
|
||
| function alert() { | ||
| const toast = new Adw.Toast({ | ||
| title: "Troubleshoot successful!", | ||
| timeout: 3, | ||
| }); | ||
|
|
||
| overlay.add_toast(toast); | ||
| } | ||
|
|
||
| // signal called when banner button is clicked | ||
| banner.connect("button-clicked", alert); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,10 @@ | ||
| { | ||
| "name": "Banner", | ||
| "category": "user_interface", | ||
| "description": "Banners is an attention-grabbing notification that is used to communicate important information.", | ||
| "panels": [ | ||
| "ui", | ||
| "preview" | ||
| ], | ||
| "autorun": true | ||
| } |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.