library: Add Menu entry #445
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andyholmes
requested changes
Jul 23, 2023
Contributor
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
Nice one.
A few teaks and I think this is good to go.
Contributor
|
@AkshayWarrier ping :) |
Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com>
andyholmes
requested changes
Aug 7, 2023
This should be visible in any color scheme.
andyholmes
approved these changes
Aug 8, 2023
Contributor
andyholmes
left a comment
andyholmes
left a comment
There was a problem hiding this comment.
No need to wait for a simple fix, since you were up late trying to get Workbench to build.
Contributor
Author
|
Thank you :) |
sonnyp
pushed a commit
to SoNiC-HeRE/Workbench
that referenced
this pull request
Aug 13, 2023
* library: Add Menu entry * Menu: Minor change from review Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com> * Set default text color to green This should be visible in any color scheme. --------- Co-authored-by: Andy Holmes <1265208+andyholmes@users.noreply.github.com> Co-authored-by: Andy Holmes <andrew.g.r.holmes@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #321