-
-
Notifications
You must be signed in to change notification settings - Fork 90
Manuals: Improve design and use TreeExpander #457
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
This is not ready to be reviewed yet, I might have an idea why it's not working. I want to try something first :) |
|
Some things to consider
|
|
For some reason, I'm unable to change the default selected item in the sidebar when the doc viewer is first opened. Scrolling in the web view is broken and also switching between sections in the documentation (when the sections are on the same page) potentially because of https://bugs.webkit.org/show_bug.cgi?id=260073 Edit: This issue is not persisting anymore after updating |
sonnyp
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
I pushed minor changes, make sure to git pull.
I think we should remove empty sections like Bitfields and Error Domains in this example.
If you prefer, you can create a follow up ticket.
When navigating back, it should select the relevant sidebar item.
This should probably be a follow up though.

This PR aims to make improvements to the Documentation Viewer.
libadwaita1.4 widgets. The Documentation Viewer now uses aNavigationSplitViewfor the sidebar.TreeExpanders