Library: Port 'Level Bars' to Python #819
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
@sonnyp There seems to be an issue with either the JavaScript or demo, I think the JS demo has the CSS not applied, but looking at the classes in the inspectors for the battery demo they don't match the classes in the CSS in either Python / JS, so I'm not sure how it's supposed to be. JS: Python: Since the Python demo actually changes color, I think that one is probably correct? |
Contributor
|
Thanks for the heads up. I fixed the issue #831 and merged in this branch. Feel free to merge this |
Contributor
|
@theCapypara can I go ahead and merge this to https://github.com/workbenchdev/demos ? |
Contributor
|
Sure! |
sonnyp
pushed a commit
to workbenchdev/demos
that referenced
this pull request
Dec 9, 2023
Contributor
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.