appdata: Improve appdata for AppStream 1.0 #861
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add the `<developer><name>` tag - Mark the `<developer_name>` tag as deprecated - Remove the second appstreamcli validation - Improve appstreamcli arguments
ghost
requested a review
from 
Hofer-Julian
approved these changes
Jan 7, 2024
Contributor
|
Thanks |
sonnyp
reviewed
Jan 7, 2024
| <name translatable="no">Workbench</name> | ||
| <!-- developer_name tag deprecated with Appstream 1.0 --> | ||
| <developer_name translatable="no">Sonny Piers</developer_name> | ||
| <developer id="gitlab.com"> |
Contributor
There was a problem hiding this comment.
This is incorrect - github.com is not the developer of Workbench
The element should have a id property, containing a unique ID to identify the respective developer. It is recommended to use a web URL, like gnome.org as ID to achieve a higher chance of uniqueness.
https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer
I will fix
Author
There was a problem hiding this comment.
I'm not sure how to use the new tag.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
<developer><name>tag<developer_name>tag as deprecated