Skip to content

appdata: Improve appdata for AppStream 1.0 #861

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Jan 7, 2024
Merged

appdata: Improve appdata for AppStream 1.0 #861

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions data/app.metainfo.xml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@
<id>@app_id@</id>
<launchable type="desktop-id">@app_id@.desktop</launchable>
<name translatable="no">Workbench</name>
<!-- developer_name tag deprecated with Appstream 1.0 -->
<developer_name translatable="no">Sonny Piers</developer_name>
<developer id="gitlab.com">
Copy link
Contributor

@sonnyp sonnyp Jan 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is incorrect - github.com is not the developer of Workbench

The element should have a id property, containing a unique ID to identify the respective developer. It is recommended to use a web URL, like gnome.org as ID to achieve a higher chance of uniqueness.

https://www.freedesktop.org/software/appstream/docs/chap-Metadata.html#tag-developer

I will fix

Copy link
Author

@ghost ghost Jan 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to use the new tag.

ximion/appstream#575

<name translatable="no">Sonny Piers</name>
</developer>
<update_contact>sonnyp@gnome.org</update_contact>
<metadata_license>CC0-1.0</metadata_license>
<project_license>GPL-3.0</project_license>
Expand Down
9 changes: 1 addition & 8 deletions data/meson.build
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,14 +29,7 @@ appstream_file = configure_file(
appstream_cli = find_program('appstreamcli', required: false)
if appstream_cli.found()
test('Validate metainfo file', appstream_cli,
args: ['validate', '--override=release-time-missing=info', '--no-net', appstream_file]
)
endif

appstreamcli = find_program('appstreamcli', required: false)
if appstreamcli.found()
test('Validate appstream file', appstreamcli,
args: ['validate', appstream_file]
args: ['validate', '--override=release-time-missing=info', '--no-net', '--explain', appstream_file]
)
endif

Expand Down