Rag run by sroussey · Pull Request #155 · workglow-dev/libs

sroussey · 2026-01-03T18:53:18Z

No description provided.

…ved input data handling for tests - Replaced structuredClone and JSON methods with a new smartClone function that deep-clones plain objects and arrays while preserving class instances by reference. - quick versions of tasks as functions now pass input to run not the constructor which means no defaults and cloning

…ng additional input properties.

Copilot

Pull request overview

This PR introduces a fundamental architectural change to how tasks are instantiated and executed, with the title "Rag run" suggesting this may be related to Retrieval-Augmented Generation workflows that require passing non-serializable objects like repositories.

Key changes:

Task constructors now receive empty type-asserted objects instead of actual input data
The run() method now accepts input as a parameter instead of using constructor-provided input
New smartClone method replaces structuredClone to handle class instances and TypedArrays by reference
Removed undefined value checks in setInput and addInput for additional properties

Reviewed changes

Copilot reviewed 35 out of 35 changed files in this pull request and generated 7 comments.

Show a summary per file

File	Description
packages/task-graph/src/task/Task.ts	Core implementation: adds smartClone method, modifies resetInputData to use it, removes undefined checks in input handling
packages/tasks/src/task/SplitTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/tasks/src/task/MergeTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/tasks/src/task/JsonTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/tasks/src/task/JavaScriptTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/tasks/src/task/FileLoaderTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/tasks/src/task/FileLoaderTask.server.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/tasks/src/task/FetchUrlTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/tasks/src/task/DelayTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/tasks/src/task/DebugLogTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/VectorSimilarityTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/VectorQuantizeTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/UnloadModelTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextTranslationTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextSummaryTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextRewriterTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextQuestionAnswerTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextNamedEntityRecognitionTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextLanguageDetectionTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextGenerationTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextFillMaskTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextEmbeddingTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/TextClassificationTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/PoseLandmarkerTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/ObjectDetectionTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/ImageToTextTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/ImageSegmentationTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/ImageEmbeddingTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/ImageClassificationTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/HandLandmarkerTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/GestureRecognizerTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/FaceLandmarkerTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/FaceDetectorTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/DownloadModelTask.ts	Updates convenience function to pass empty object to constructor and input to run()
packages/ai/src/task/BackgroundRemovalTask.ts	Updates convenience function to pass empty object to constructor and input to run()

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Copilot · 2026-01-03T19:19:46Z

+  private smartClone(obj: any): any {
+    if (obj === null || obj === undefined) {
+      return obj;
+    }
+
+    // Preserve TypedArrays (Float32Array, Int8Array, etc.) by reference
+    // These are often large and cloning them is expensive
+    if (ArrayBuffer.isView(obj)) {
+      return obj;
    }
+
+    // Preserve class instances (objects with non-Object/non-Array prototype)
+    // This includes repository instances, custom classes, etc.
+    if (typeof obj === "object" && !Array.isArray(obj)) {
+      const proto = Object.getPrototypeOf(obj);
+      if (proto !== Object.prototype && proto !== null) {
+        return obj; // Pass by reference
+      }
+    }
+
+    // Deep clone arrays, preserving class instances within
+    if (Array.isArray(obj)) {
+      return obj.map((item) => this.smartClone(item));
+    }
+
+    // Deep clone plain objects
+    if (typeof obj === "object") {
+      const result: Record<string, any> = {};
+      for (const key in obj) {
+        if (Object.prototype.hasOwnProperty.call(obj, key)) {
+          result[key] = this.smartClone(obj[key]);
+        }
+      }
+      return result;
+    }
+
+    // Primitives (string, number, boolean, symbol, bigint) are returned as-is
+    return obj;


The smartClone implementation has a potential issue with circular references in plain objects and arrays. While class instances are passed by reference (avoiding circular reference issues), if a plain object or array contains circular references, this method will cause infinite recursion and stack overflow. Consider adding circular reference detection or documenting this limitation clearly.

@copilot open a new pull request to apply changes based on this feedback. detect circular references

Copilot · 2026-01-04T00:52:00Z

@sroussey I've opened a new pull request, #162, to work on those changes. Once the pull request is ready, I'll request review from you.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initial plan * Add circular reference detection to smartClone method Co-authored-by: sroussey <127349+sroussey@users.noreply.github.com> * Fix circular reference detection to handle shared references correctly Co-authored-by: sroussey <127349+sroussey@users.noreply.github.com> * Refactor TaskEvents to import TaskStatus from TaskTypes and add unit tests for smartClone method - Updated TaskEvents to import TaskStatus from the correct module. - Added comprehensive unit tests for the smartClone method, including cases for circular reference detection and handling various data structures. --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: sroussey <127349+sroussey@users.noreply.github.com> Co-authored-by: Steven Roussey <sroussey@gmail.com>

sroussey added 2 commits January 3, 2026 18:27

[refactor] Removed unnecessary checks for undefined values when copyi…

0642c22

…ng additional input properties.

github-actions Bot assigned sroussey Jan 3, 2026

sroussey requested a review from Copilot January 3, 2026 19:15

Copilot started reviewing on behalf of sroussey January 3, 2026 19:16 View session

Copilot AI reviewed Jan 3, 2026

View reviewed changes

Copilot AI mentioned this pull request Jan 4, 2026

Add circular reference detection to smartClone method #162

Merged

sroussey and others added 2 commits January 4, 2026 00:53

Update packages/task-graph/src/task/Task.ts

223af65

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

sroussey closed this Jan 4, 2026

sroussey deleted the rag-run branch April 11, 2026 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rag run#155

Rag run#155
sroussey wants to merge 4 commits intorag-docfrom
rag-run

sroussey commented Jan 3, 2026

Uh oh!

Copilot AI left a comment

Uh oh!

Copilot AI Jan 3, 2026

Uh oh!

sroussey Jan 4, 2026

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

sroussey commented Jan 3, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Copilot AI Jan 3, 2026

Choose a reason for hiding this comment

Uh oh!

sroussey Jan 4, 2026

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Jan 4, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants