Skip to content

Extract magic number to named constant in ProvenanceUtils #159

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sroussey merged 2 commits into from
Jan 4, 2026
Merged

Extract magic number to named constant in ProvenanceUtils #159

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1883b35
Initial plan
Copilot Jan 4, 2026
c9114c2
Extract magic number 512 to DEFAULT_MAX_TOKENS constant
Copilot Jan 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion packages/ai/src/source/ProvenanceUtils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,11 @@ import { sha256 } from "@workglow/util";

import type { VariantProvenance } from "./DocumentSchema";

/**
* Default maximum tokens for chunking when not specified in provenance
*/
const DEFAULT_MAX_TOKENS = 512;

/**
* Extract variant-relevant fields from task-graph provenance
*/
Expand Down Expand Up @@ -79,7 +84,7 @@ function extractNumber(prov: Provenance, ...keys: string[]): number {
}
}
// Default for required field
return 512; // Default maxTokens
return DEFAULT_MAX_TOKENS;
}

/**
Expand Down