fix: correct JSDoc on McpServerConfigSchema to describe actual resolver mechanics#310
Merged
sroussey merged 2 commits intoclaude/add-mcp-task-registry-y9KGEfrom Mar 14, 2026
Merged
Conversation
…ibe resolution mechanism Co-authored-by: sroussey <127349+sroussey@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] [WIP] Address feedback on MCP server registry and task server references
fix: correct JSDoc on McpServerConfigSchema to describe actual resolver mechanics
Mar 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The previous doc comment incorrectly stated that
server_idinsideMcpServerConfigSchemais what the input resolver acts on. In reality, the resolver acts on task input properties annotated withformat: "mcp-server"— when such a property (e.g.server) receives a plain string, the resolver substitutes the full server config object from the registry.Changes
McpServerSchema.ts: Rewrote theMcpServerConfigSchemaJSDoc to correctly describe that theformat: "mcp-server"annotation on the schema type is what triggers resolution, and that resolution occurs on the consuming task's input property (not onserver_idwithin this schema).🔒 GitHub Advanced Security automatically protects Copilot coding agent pull requests. You can protect all pull requests by enabling Advanced Security for your repositories. Learn more about Advanced Security.