feat: Segments are now optional #18
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR makes logger segments optional by changing the withText, withError, and withObject methods to accept optional parameters and only log entries when values are provided.
- Made text, error, and object parameters optional in logger interface methods
- Added conditional checks to prevent logging when parameters are undefined
- Updated tests to verify the new optional behavior and reorganized existing test cases
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| packages/logging/src/Logger.ts | Updated interface to make withText, withError, and withObject parameters optional |
| packages/logging/src/BrowserConsoleLogger.ts | Added conditional checks and parameter optionality for logging methods |
| packages/logging/src/CompositeLogger.ts | Added conditional checks and parameter optionality for composite logger methods |
| packages/logging/tests/BrowserConsoleLogger.test.ts | Added tests for undefined parameters and reorganized existing test cases |
| packages/logging/tests/CompositeLogger.test.ts | Added tests for undefined parameters and updated test data |
| .changeset/icy-worms-open.md | Added changeset documentation for the feature |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
commit: |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.