chore: Improve Claude setup#549
Merged
Merged
Conversation
… data fetching, deferred registrations, routing and navigation, testing, agent skills, build tooling, CI/CD pipeline, development guide, release process, and writing agent instructions
Copilot started reviewing on behalf of
Patrick Lafrance (patricklafrance)
March 2, 2026 17:03
View session
@squide/core
@squide/env-vars
@squide/fakes
@squide/firefly
@squide/firefly-module-federation
@squide/firefly-rsbuild-configs
@squide/firefly-rsbuild-storybook
@squide/firefly-webpack-configs
@squide/i18next
@squide/launch-darkly
@squide/msw
@squide/react-router
commit: |
There was a problem hiding this comment.
Pull request overview
Adds a structured agent-docs/ knowledge base (design, references, quality, specs) and updates root navigation/prompt files to point at the new layout, improving Claude/agent documentation discoverability.
Changes:
- Introduces new agent documentation pages under
agent-docs/{design,references,quality,specs}. - Updates
CLAUDE.mdandagent-docs/ARCHITECTURE.mdto link to the new paths (removing the oldagent-docs/docs/...layout). - Updates GitHub prompt files and ODR references to use the new documentation locations.
Reviewed changes
Copilot reviewed 6 out of 18 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| agent-docs/specs/README.md | Adds package-spec index for @squide/* packages. |
| agent-docs/references/writing-agent-instructions.md | Documents principles for writing agent instructions. |
| agent-docs/references/release-process.md | Documents Changesets-based release flow. |
| agent-docs/references/development.md | Adds development conventions/commands (pnpm, env vars, Retype, etc.). |
| agent-docs/references/ci-cd.md | Documents CI workflows and dogfood/smoke operational details. |
| agent-docs/references/build-tooling.md | Summarizes build tooling layers and shared configs. |
| agent-docs/references/agent-skills.md | Explains skill directories and editing rules. |
| agent-docs/quality/testing.md | Defines validation steps and browser QA expectations. |
| agent-docs/odr/index.md | Fixes ODR index row formatting/typo. |
| agent-docs/odr/0009-ai-driven-browser-qa-in-ci.md | Updates link to CI/CD reference after doc move. |
| agent-docs/design/routing-and-navigation.md | Captures route/nav registration patterns and key hooks. |
| agent-docs/design/deferred-registrations.md | Documents two-phase/deferred registration behavior. |
| agent-docs/design/data-fetching.md | Documents global data fetching orchestration and errors. |
| agent-docs/design/cross-module-communication.md | Documents event bus/plugins and module boundaries. |
| agent-docs/ARCHITECTURE.md | Updates design/spec links to match the new agent-docs/ structure. |
| CLAUDE.md | Updates the Memory Index links to the new doc paths. |
| .github/prompts/update-agent-docs.md | Updates documented agent-docs layout and internal links. |
| .github/prompts/code-review.md | Updates link to the new location of agent-skills.md. |
Patrick Lafrance (patricklafrance)
merged commit ab4af5f
into
main
11 of 12 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.