fix: drop GitHub App token from release-please workflow#36
Conversation
The app token was cargo-culted from authkit-tanstack-start where it's needed for cross-workflow triggers. With publishing inlined into this same workflow, GITHUB_TOKEN is sufficient.
Greptile SummaryThis PR simplifies the release-please workflow by removing the GitHub App token step and letting the action use the default
Confidence Score: 5/5Safe to merge — both changes are straightforward removals/additions with no risk to the release or publish flow. Removing the GitHub App token is correct here: the No files require special attention. Important Files Changed
|
Summary
create-github-app-tokenstep from the release-please workflowGITHUB_TOKENinsteadCHANGELOG.mdfrom oxfmt formattingWhy
The GitHub App token (failed run) was cargo-culted from authkit-tanstack-start where it's needed for cross-workflow triggers. With publishing inlined into the same workflow,
GITHUB_TOKENis sufficient — release-please getscontents: write+pull-requests: writefrom the workflow permissions.No
NPM_TOKENneeded — publishing uses npm trusted publishing via OIDC (id-token: write+--provenance).Test plan