fix: correct skills directory path resolution in getSkillsDir#79
Merged
fix: correct skills directory path resolution in getSkillsDir#79
Conversation
The path walked up 3 levels assuming dist/src/commands/ structure, but tsconfig rootDir strips the src/ prefix, producing dist/commands/. This caused ENOENT when running install-skill.
Walks up to package.json instead of counting '../' segments from compiled output. Prevents path resolution from silently breaking when tsconfig output structure changes.
This was referenced Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ENOENT: no such file or directory, scandirerror when runningworkos install-skillgetSkillsDir()walked up 3 parent directories assumingdist/src/commands/output structure, buttsconfig.jsonhasrootDir: "./src"which strips thesrc/prefix, producingdist/commands/. The extra..caused the path to overshoot the repo root.Test plan
workos install-skill --listand verify it discovers skillsworkos install-skilland verify skills install to detected agents