Merged
Conversation
marktran
reviewed
Jan 27, 2021
package.json
Outdated
| @@ -1,5 +1,5 @@ | |||
| { | |||
| "version": "0.8.4", | |||
| "version": "0.8.5", | |||
Member
There was a problem hiding this comment.
Can you break the version bump into a separate PR?
PRs get squashed into a single commit so we want the ability to easily revert functionality.
Contributor
Author
There was a problem hiding this comment.
@marktran Absolutely, I'll update shortly 👍
Contributor
There was a problem hiding this comment.
Also, since we're adding functionality we should be bumping the minor version to follow SemVer:
- MINOR version when you add functionality in a backwards compatible manner, and
Contributor
Author
There was a problem hiding this comment.
Added a commit reverting package.json version and snapshots back to 0.8.4
Contributor
Author
There was a problem hiding this comment.
@maxdeviant I can plan for a bump to 0.9.0 (sorry, bit of a new area for me 😅 )
Co-authored-by: Mark Tran <mark.tran@gmail.com>
…f github.com:workos-inc/workos-node into feature/sdk-17-add-delete-connectionsid-for-node-sdk
logangingerich
changed the title
maxdeviant
approved these changes
Jan 29, 2021
logangingerich
deleted the
feature/sdk-17-add-delete-connectionsid-for-node-sdk
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://linear.app/workos/issue/SDK-17/add-delete-connectionsid-for-node-sdk
Adds a
deleteConnectionmethod to wrapDELETE /connections/:idendpoint.