Expose data and params kwargs for request helper #16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #16 +/- ##
==========================================
- Coverage 96.35% 96.26% -0.09%
==========================================
Files 8 8
Lines 137 134 -3
==========================================
- Hits 132 129 -3
Misses 5 5
Continue to review full report at Codecov.
|
maxchehab
reviewed
Mar 18, 2020
workos/utils/request.py
Outdated
| request_fn = getattr(requests, method) | ||
| if method == REQUEST_METHOD_GET: | ||
| response = request_fn(url, headers=headers, params=params) | ||
| response = request_fn(url, headers=headers, data=data, params=params) |
Contributor
There was a problem hiding this comment.
Should we be sending any data during a GET request?
henrylamchan
force-pushed
the
202003_expose_data_and_params_for_request_helper
branch
from
5377714 to
e165905
Compare
henrylamchan
deleted the
202003_expose_data_and_params_for_request_helper
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Expose data and params for the request helper as pass through kwargs. This'd allow to make the oauth post call with query params. Straightforward abstraction that I hope doesn't cause much confusion in the future.