Rename endpoints when fetching Directory Groups and Users #23
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henrylamchan
approved these changes
Apr 22, 2020
Contributor
henrylamchan
left a comment
henrylamchan
left a comment
There was a problem hiding this comment.
Code looks good. Had one question about the directories and directory_users endpoints
| ) | ||
|
|
||
| def get_user(self, directory_endpoint_id, directory_user_id): | ||
| def get_user(self, directory, directory_user): |
Contributor
There was a problem hiding this comment.
I have no in depth knowledge of the app side changes or dsync in general but... is getting a user not doable via the directory_users endpoint?
Contributor
Author
There was a problem hiding this comment.
You definitely can, but the directory_users endpoint gives back a paginated list. I think it's still good to have a way to retrieve a single record.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Directory EndpointtoDirectory_idfrom Directory Sync kwargs/directory_usersinstead of/directories/:id/users/directory_groupsinstead of/directories/:id/groups