Skip to content

Fix enum to string conversion in get_authorization_url #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rohanjadvani merged 1 commit into from
May 13, 2020
Merged

Fix enum to string conversion in get_authorization_url #28

rohanjadvani merged 1 commit into from
May 13, 2020

Conversation

@rohanjadvani
Copy link
Contributor

@rohanjadvani rohanjadvani commented May 13, 2020

  • Update method documentation to indicate provider is a ConnectionType
  • Convert enum value for Authorization URL

maxchehab
maxchehab approved these changes May 13, 2020
View reviewed changes
Copy link
Contributor

@maxchehab maxchehab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@codecov
Copy link

codecov bot commented May 13, 2020

Codecov Report

Merging #28 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #28   +/-   ##
=======================================
  Coverage   97.14%   97.14%           
=======================================
  Files           9        9           
  Lines         175      175           
=======================================
  Hits          170      170           
  Misses          5        5

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 136f6da...e522e26. Read the comment docs.

@rohanjadvani rohanjadvani merged commit 0c640da into master May 13, 2020
@rohanjadvani rohanjadvani deleted the rohanjadvani/provider-enum-validation branch May 13, 2020 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@marktran marktran Awaiting requested review from marktran

@henrylamchan henrylamchan Awaiting requested review from henrylamchan

1 more reviewer

@maxchehab maxchehab maxchehab approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@rohanjadvani @maxchehab