Skip to content

Update state type from dict to string #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
rohanjadvani merged 1 commit into from
May 28, 2020
Merged

Update state type from dict to string #30

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 4 additions & 6 deletions tests/test_sso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,9 +15,7 @@ def setup(self, set_api_key_and_project_id):
self.provider = ConnectionType.GoogleOAuth
self.customer_domain = "workos.com"
self.redirect_uri = "https://localhost/auth/callback"
self.state = {
"things": "with_stuff",
}
self.state = json.dumps({"things": "with_stuff",})

self.sso = SSO()

Expand Down Expand Up @@ -84,7 +82,7 @@ def test_authorization_url_has_expected_query_params_with_provider(self):
"client_id": workos.project_id,
"redirect_uri": self.redirect_uri,
"response_type": RESPONSE_TYPE_CODE,
"state": json.dumps(self.state),
"state": self.state,
}

def test_authorization_url_has_expected_query_params_with_domain(self):
Expand All @@ -101,7 +99,7 @@ def test_authorization_url_has_expected_query_params_with_domain(self):
"client_id": workos.project_id,
"redirect_uri": self.redirect_uri,
"response_type": RESPONSE_TYPE_CODE,
"state": json.dumps(self.state),
"state": self.state,
}

def test_authorization_url_has_expected_query_params_with_domain_and_provider(self):
Expand All @@ -120,7 +118,7 @@ def test_authorization_url_has_expected_query_params_with_domain_and_provider(se
"client_id": workos.project_id,
"redirect_uri": self.redirect_uri,
"response_type": RESPONSE_TYPE_CODE,
"state": json.dumps(self.state),
"state": self.state,
}

def test_get_profile_returns_expected_workosprofile_object(
Expand Down
4 changes: 2 additions & 2 deletions workos/sso.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ def get_authorization_url(
Kwargs:
domain (str) - The domain a user is associated with, as configured on WorkOS
redirect_uri (str) - A valid redirect URI, as specified on WorkOS
state (dict) - A dict passed to WorkOS, that'd be preserved through the authentication workflow, passed
state (str) - An encoded string passed to WorkOS that'd be preserved through the authentication workflow, passed
back as a query parameter
provider (ConnectionType) - Authentication service provider descriptor

Expand All @@ -67,7 +67,7 @@ def get_authorization_url(
params["domain"] = domain

if state is not None:
params["state"] = json.dumps(state)
params["state"] = state

prepared_request = Request(
"GET",
Expand Down