Skip to content

chore: mark non-spec service accessors with @oagen-ignore-start/end#613

Merged
gjtorikian merged 1 commit intomainfrom
hand-maintain-non-spec-accessors
Apr 14, 2026
Merged

chore: mark non-spec service accessors with @oagen-ignore-start/end#613
gjtorikian merged 1 commit intomainfrom
hand-maintain-non-spec-accessors

Conversation

@gjtorikian
Copy link
Copy Markdown
Contributor

Previously, oagen-emitters generated methods for APIs not in the OpenAPI spec—stuff like Vault, PKCE, etc. This was kind of gross and unnecessary, so I removed the functionality in workos/oagen-emitters@7b0bab4 and am just tagging the relevant code sections with oagen-ignore, so that they do not get removed upon regeneration.

@gjtorikian gjtorikian requested review from a team as code owners April 14, 2026 16:38
@gjtorikian gjtorikian merged commit 807437c into main Apr 14, 2026
10 checks passed
@gjtorikian gjtorikian deleted the hand-maintain-non-spec-accessors branch April 14, 2026 16:39
@greptile-apps
Copy link
Copy Markdown
Contributor

greptile-apps bot commented Apr 14, 2026

Greptile Summary

This PR protects the hand-maintained, non-spec service sections in src/workos/_client.py (imports and accessors for passwordless, vault, actions, and pkce) from being erased by the oagen code generator on future regenerations, by wrapping them with @oagen-ignore-start/@oagen-ignore-end comment markers. The .oagen-manifest.json timestamp is updated to reflect the regeneration run.

Confidence Score: 5/5

  • This PR is safe to merge — it adds comment markers only and makes no logic changes.
  • All changes are purely structural comment annotations (@oagen-ignore-start/@oagen-ignore-end) that protect existing hand-maintained code from future code-generator overwrites. No logic, behaviour, or API surface is altered. No P0 or P1 findings.
  • No files require special attention.

Important Files Changed

Filename Overview
src/workos/_client.py Adds @oagen-ignore-start/end markers around non-spec imports (passwordless, vault, actions, pkce) and their service accessors in both WorkOSClient and AsyncWorkOSClient to prevent the code generator from removing them on future regenerations. No logic changes.
.oagen-manifest.json Timestamp update reflecting when the file was last regenerated; no structural changes.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[oagen runs regeneration] --> B{Section in _client.py}
    B -->|Auto-generated region| C[Overwrite with spec output]
    B -->|Ignore-marked region| D[Preserve as-is]
    D --> E[passwordless imports and accessors]
    D --> F[vault imports and accessors]
    D --> G[actions imports and accessors]
    D --> H[pkce imports and accessors]
    C --> I[spec-generated services: sso, user_management, etc.]
Loading

Reviews (1): Last reviewed commit: "chore: mark non-spec service accessors w..." | Re-trigger Greptile

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

1 participant