fix: backport SSO Profile custom_attributes to 5.9.x (5.9.1)#677
Merged
Conversation
(cherry picked from commit aa98f87)
Contributor
Greptile SummaryThis PR backports SSO profile custom attributes to the
Confidence Score: 5/5The changes are narrowly scoped to a model field backport, fixture updates, and a patch version bump, with no issues identified. The implementation aligns with the described compatibility goal and the touched files are limited to the SSO profile type, tests, fixtures, and package metadata.
What T-Rex did
Reviews (1): Last reviewed commit: "chore: bump version to 5.9.1" | Re-trigger Greptile |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requested by Adam Jenkins · Slack thread
Description
What / why
A customer is pinned to SDK
5.9.0and cannot easily upgrade to5.20.0, where the SSO Profilecustom_attributesfield was added. This backports just that field as a5.9.1patch so they can readcustom_attributes(the replacement for the deprecatedraw_attributes) without taking a major version upgrade.How
v5.9.0tag — zero conflicts.custom_attributesto the SSOProfilemodel and makesraw_attributesoptional. This is the one behavioral note, and it is backward-compatible for reads.custom_attributesin 5.9.0, so no changes are needed there.5.9.0->5.9.1inworkos/__about__.py.This PR targets a new maintenance branch
5.9.x(created from thev5.9.0tag) rather thanmain.Testing
python -m pytest tests/test_sso.py-> 26 passed.Documentation
Does this require changes to the WorkOS Docs? E.g. the API Reference or code snippets need updates.
If yes, link a related docs PR and add a docs maintainer as a reviewer. Their approval is required.