feat(generated): Pipes (batch 8ad8e447) - #550
Conversation
Greptile SummaryThis generated SDK update adds connected-account selection to Pipes credential, token, lookup, update, and deletion operations and exposes plural connected accounts in list responses.
Confidence Score: 4/5The PR should not merge until the RBI preserves the new keyword's optional runtime contract; the remaining findings are non-blocking test-coverage improvements. All five runtime methods permit callers to omit Files Needing Attention: rbi/workos/pipes.rbi, lib/workos/pipes.rb, test/workos/test_pipes_model_round_trip.rb Important Files Changed
|
| ).returns(WorkOS::DataIntegrationCredentialsResponse) | ||
| end | ||
| def create_data_integration_credential(slug:, user_id:, organization_id:, request_options:); end | ||
| def create_data_integration_credential(slug:, user_id:, organization_id:, connected_account_id:, request_options:); end |
There was a problem hiding this comment.
Optional keyword declared required
The Ruby methods allow callers to omit connected_account_id by defaulting it to nil, but these RBI declarations make the keyword required. Existing Sorbet callers that omit it will therefore get a missing-keyword error even though the call is valid at runtime. Preserve the runtime default in all five updated Pipes declarations.
Prompt To Fix With AI
This is a comment left during a code review.
Path: rbi/workos/pipes.rbi
Line: 114
Comment:
**Optional keyword declared required**
The Ruby methods allow callers to omit `connected_account_id` by defaulting it to `nil`, but these RBI declarations make the keyword required. Existing Sorbet callers that omit it will therefore get a missing-keyword error even though the call is valid at runtime. Preserve the runtime default in all five updated Pipes declarations.
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.| "updated_at" => "stub", | ||
| "connected_account" => nil | ||
| "connected_account" => nil, | ||
| "connected_accounts" => [] |
There was a problem hiding this comment.
Nested accounts remain untested
The new fixture uses an empty connected_accounts array, so it never exercises construction or serialization of a nested connected-account model. Use at least one representative account and assert its nested values; otherwise an incorrect element class or serialization mapping could pass this test.
Knowledge Base Used: Connect, Pipes, and Admin Portal
Prompt To Fix With AI
This is a comment left during a code review.
Path: test/workos/test_pipes_model_round_trip.rb
Line: 244
Comment:
**Nested accounts remain untested**
The new fixture uses an empty `connected_accounts` array, so it never exercises construction or serialization of a nested connected-account model. Use at least one representative account and assert its nested values; otherwise an incorrect element class or serialization mapping could pass this test.
**Knowledge Base Used:** [Connect, Pipes, and Admin Portal](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-ruby/-/docs/connect-pipes-and-admin-portal.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
| "user_id" => user_id, | ||
| "organization_id" => organization_id | ||
| "organization_id" => organization_id, | ||
| "connected_account_id" => connected_account_id |
There was a problem hiding this comment.
Account selector serialization untested
None of the five updated operations has a request test that supplies connected_account_id and checks where it is serialized. Add coverage for both the POST-body and query-parameter forms so a future generator regression cannot silently place the account selector in the wrong part of the request.
Knowledge Base Used: Connect, Pipes, and Admin Portal
Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/workos/pipes.rb
Line: 299
Comment:
**Account selector serialization untested**
None of the five updated operations has a request test that supplies `connected_account_id` and checks where it is serialized. Add coverage for both the POST-body and query-parameter forms so a future generator regression cannot silently place the account selector in the wrong part of the request.
**Knowledge Base Used:** [Connect, Pipes, and Admin Portal](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-ruby/-/docs/connect-pipes-and-admin-portal.md)
---
For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
Summary
Regenerated SDK from spec changes.
Triggered by workos/openapi-spec@b110a04