Skip to content

feat(generated): Pipes (batch 8ad8e447) - #550

Merged
workos-sdk-automation[bot] merged 2 commits into
mainfrom
oagen/batch-8ad8e447
Sep 5, 2026
Merged

feat(generated): Pipes (batch 8ad8e447)#550
workos-sdk-automation[bot] merged 2 commits into
mainfrom
oagen/batch-8ad8e447

Conversation

@workos-sdk-automation

Copy link
Copy Markdown
Contributor

Summary

Regenerated SDK from spec changes.

Triggered by workos/openapi-spec@b110a04

@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 5, 2026
@workos-sdk-automation
workos-sdk-automation Bot requested review from a team as code owners September 5, 2026 15:36
@workos-sdk-automation workos-sdk-automation Bot added the autogenerated Autogenerated code or content label Sep 5, 2026
@greptile-apps

greptile-apps Bot commented Sep 5, 2026

Copy link
Copy Markdown
Contributor

Greptile Summary

This generated SDK update adds connected-account selection to Pipes credential, token, lookup, update, and deletion operations and exposes plural connected accounts in list responses.

  • Adds connected_account_id to request models, runtime methods, and RBI declarations.
  • Adds connected_accounts model deserialization and serialization support.
  • Updates generated round-trip fixtures and synchronization metadata.
  • The RBI currently makes the new runtime-optional keyword required for typed callers.

Confidence Score: 4/5

The PR should not merge until the RBI preserves the new keyword's optional runtime contract; the remaining findings are non-blocking test-coverage improvements.

All five runtime methods permit callers to omit connected_account_id, while their updated RBI declarations require it, breaking otherwise valid typed calls. The response-model implementation itself follows established serialization patterns.

Files Needing Attention: rbi/workos/pipes.rbi, lib/workos/pipes.rb, test/workos/test_pipes_model_round_trip.rb

Important Files Changed

Filename Overview
lib/workos/pipes.rb Adds optional connected-account selectors to five Pipes operations, but corresponding request serialization is not directly tested.
rbi/workos/pipes.rbi Adds the selector to typed method declarations but incorrectly models the runtime-optional keyword as required.
lib/workos/pipes/data_integrations_list_response_data.rb Adds plural connected-account mapping using the established nested-model array pattern.
test/workos/test_pipes_model_round_trip.rb Updates generated fixtures, although the empty plural-account fixture does not exercise nested conversion.
test/workos/test_shared_model_round_trip.rb Reorders four existing round-trip tests without changing their assertions or coverage.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart LR
  App[Ruby application] --> Pipes[WorkOS::Pipes]
  Pipes --> Credential[Credential request body]
  Pipes --> Token[Token request body]
  Pipes --> Lifecycle[Account lifecycle query]
  Credential --> Selector[connected_account_id]
  Token --> Selector
  Lifecycle --> Selector
  API[WorkOS API] --> List[Data integration list response]
  List --> Accounts[connected_accounts]
  Accounts --> Model[Connected-account models]
Loading
Prompt To Fix All With AI
### Issue 1
rbi/workos/pipes.rbi:114
**Optional keyword declared required**

The Ruby methods allow callers to omit `connected_account_id` by defaulting it to `nil`, but these RBI declarations make the keyword required. Existing Sorbet callers that omit it will therefore get a missing-keyword error even though the call is valid at runtime. Preserve the runtime default in all five updated Pipes declarations.

### Issue 2
test/workos/test_pipes_model_round_trip.rb:244
**Nested accounts remain untested**

The new fixture uses an empty `connected_accounts` array, so it never exercises construction or serialization of a nested connected-account model. Use at least one representative account and assert its nested values; otherwise an incorrect element class or serialization mapping could pass this test.

### Issue 3
lib/workos/pipes.rb:299
**Account selector serialization untested**

None of the five updated operations has a request test that supplies `connected_account_id` and checks where it is serialized. Add coverage for both the POST-body and query-parameter forms so a future generator regression cannot silently place the account selector in the wrong part of the request.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Reviews (1): Last reviewed commit: "chore(generated): add release notes frag..." | Re-trigger Greptile

Comment thread rbi/workos/pipes.rbi
).returns(WorkOS::DataIntegrationCredentialsResponse)
end
def create_data_integration_credential(slug:, user_id:, organization_id:, request_options:); end
def create_data_integration_credential(slug:, user_id:, organization_id:, connected_account_id:, request_options:); end

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Optional keyword declared required

The Ruby methods allow callers to omit connected_account_id by defaulting it to nil, but these RBI declarations make the keyword required. Existing Sorbet callers that omit it will therefore get a missing-keyword error even though the call is valid at runtime. Preserve the runtime default in all five updated Pipes declarations.

Prompt To Fix With AI
This is a comment left during a code review.
Path: rbi/workos/pipes.rbi
Line: 114

Comment:
**Optional keyword declared required**

The Ruby methods allow callers to omit `connected_account_id` by defaulting it to `nil`, but these RBI declarations make the keyword required. Existing Sorbet callers that omit it will therefore get a missing-keyword error even though the call is valid at runtime. Preserve the runtime default in all five updated Pipes declarations.

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

"updated_at" => "stub",
"connected_account" => nil
"connected_account" => nil,
"connected_accounts" => []

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Nested accounts remain untested

The new fixture uses an empty connected_accounts array, so it never exercises construction or serialization of a nested connected-account model. Use at least one representative account and assert its nested values; otherwise an incorrect element class or serialization mapping could pass this test.

Knowledge Base Used: Connect, Pipes, and Admin Portal

Prompt To Fix With AI
This is a comment left during a code review.
Path: test/workos/test_pipes_model_round_trip.rb
Line: 244

Comment:
**Nested accounts remain untested**

The new fixture uses an empty `connected_accounts` array, so it never exercises construction or serialization of a nested connected-account model. Use at least one representative account and assert its nested values; otherwise an incorrect element class or serialization mapping could pass this test.

**Knowledge Base Used:** [Connect, Pipes, and Admin Portal](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-ruby/-/docs/connect-pipes-and-admin-portal.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

Comment thread lib/workos/pipes.rb
"user_id" => user_id,
"organization_id" => organization_id
"organization_id" => organization_id,
"connected_account_id" => connected_account_id

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Account selector serialization untested

None of the five updated operations has a request test that supplies connected_account_id and checks where it is serialized. Add coverage for both the POST-body and query-parameter forms so a future generator regression cannot silently place the account selector in the wrong part of the request.

Knowledge Base Used: Connect, Pipes, and Admin Portal

Prompt To Fix With AI
This is a comment left during a code review.
Path: lib/workos/pipes.rb
Line: 299

Comment:
**Account selector serialization untested**

None of the five updated operations has a request test that supplies `connected_account_id` and checks where it is serialized. Add coverage for both the POST-body and query-parameter forms so a future generator regression cannot silently place the account selector in the wrong part of the request.

**Knowledge Base Used:** [Connect, Pipes, and Admin Portal](https://app.greptile.com/workos/-/custom-context/knowledge-base/workos/workos-ruby/-/docs/connect-pipes-and-admin-portal.md)

---

For each issue above, determine whether it is valid and should be fixed. If so, fix it directly.

Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

@workos-sdk-automation
workos-sdk-automation Bot merged commit 429d26d into main Sep 5, 2026
8 checks passed
@workos-sdk-automation
workos-sdk-automation Bot deleted the oagen/batch-8ad8e447 branch September 5, 2026 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

autogenerated Autogenerated code or content

Development

Successfully merging this pull request may close these issues.

0 participants