Skip to content

Updates Gemlock to 2.2.1#151

Closed
adamzinder wants to merge 2 commits intomainfrom
bumps_version_2_2_1
Closed

Updates Gemlock to 2.2.1#151
adamzinder wants to merge 2 commits intomainfrom
bumps_version_2_2_1

Conversation

@adamzinder
Copy link
Copy Markdown
Contributor

bumps_version_2_2_1

bumps_version_2_2_1
@codecov-commenter
Copy link
Copy Markdown

Codecov Report

Merging #151 (92bd466) into master (4d2edf3) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #151   +/-   ##
=======================================
  Coverage   98.29%   98.29%           
=======================================
  Files          38       38           
  Lines         822      822           
=======================================
  Hits          808      808           
  Misses         14       14           

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

@robframpton
Copy link
Copy Markdown
Contributor

Actually looks like we need to update the version in lib/workos/version.rb as well.

@mthadley
Copy link
Copy Markdown
Contributor

Should we wait until #148 is merged before merging this version bump?

That way we don't have two version bumps super close together.

@ams11
Copy link
Copy Markdown
Contributor

ams11 commented Apr 15, 2022

Should we wait until #148 is merged before merging this version bump?

That way we don't have two version bumps super close together.

There's going to be a small followup to #148 coming as well, would love to wait to include both of those in the next version 🙏

@ams11
Copy link
Copy Markdown
Contributor

ams11 commented Apr 27, 2022

I went ahead and opened #154 to create a new gem version, now that #148 and #152 are in (I also forgot that we already had this PR open 🤦). Do we have any preferences between updating this PR with the latest changes in main or just going ahead with #154? I'm happy to go with either one...

@adamzinder
Copy link
Copy Markdown
Contributor Author

@ams11 feel free to move forward with #154. I'll close this one out!

@adamzinder adamzinder closed this Apr 27, 2022
@mthadley mthadley deleted the bumps_version_2_2_1 branch April 11, 2024 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

5 participants