Skip to content

Expose raw_attributes on WorkOS::Profile#46

Merged
willmanduffy merged 1 commit intomasterfrom
feature/ch2885/add-profile-raw-attributes-to-ruby-sdk
Aug 25, 2020
Merged

Expose raw_attributes on WorkOS::Profile#46
willmanduffy merged 1 commit intomasterfrom
feature/ch2885/add-profile-raw-attributes-to-ruby-sdk

Conversation

@willmanduffy
Copy link
Copy Markdown
Contributor

  • On the API, we recently exposed raw_attributes, the original profile
    response we receive from the IdP. This update passes this data through
    the SDK.
  • Updates the SDK to 0.5.0

Copy link
Copy Markdown
Contributor

@henrylamchan henrylamchan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. I'm assuming this is blocked on the codecov upgrade pr yea?

@willmanduffy willmanduffy force-pushed the feature/ch2885/add-profile-raw-attributes-to-ruby-sdk branch from edbdf96 to d8940d1 Compare August 24, 2020 15:19
@willmanduffy
Copy link
Copy Markdown
Contributor Author

@henrylamchan Yup! Just rebased off of it!

@willmanduffy willmanduffy force-pushed the feature/ch2885/add-profile-raw-attributes-to-ruby-sdk branch 2 times, most recently from 9a04cc5 to e048a49 Compare August 24, 2020 15:30
@codecov
Copy link
Copy Markdown

codecov bot commented Aug 24, 2020

Codecov Report

Merging #46 into master will increase coverage by 0.38%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #46      +/-   ##
==========================================
+ Coverage   98.49%   98.87%   +0.38%     
==========================================
  Files          13       13              
  Lines         265      267       +2     
==========================================
+ Hits          261      264       +3     
+ Misses          4        3       -1     
Impacted Files Coverage Δ
lib/workos/profile.rb 96.15% <100.00%> (+4.15%) ⬆️
lib/workos/types/profile_struct.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 68a18ea...c5b16fd. Read the comment docs.

* On the API, we recently exposed raw_attributes, the original profile
response we receive from the IdP. This update passes this data through
the SDK.
* Updates the SDK to 0.5.0
@willmanduffy willmanduffy force-pushed the feature/ch2885/add-profile-raw-attributes-to-ruby-sdk branch from e048a49 to c5b16fd Compare August 24, 2020 15:37
@willmanduffy willmanduffy merged commit af47110 into master Aug 25, 2020
@willmanduffy willmanduffy deleted the feature/ch2885/add-profile-raw-attributes-to-ruby-sdk branch August 25, 2020 15:47
blairworkos pushed a commit that referenced this pull request Jan 29, 2021
* On the API, we recently exposed raw_attributes, the original profile
response we receive from the IdP. This update passes this data through
the SDK.
* Updates the SDK to 0.5.0
blairworkos pushed a commit that referenced this pull request Mar 3, 2021
* On the API, we recently exposed raw_attributes, the original profile
response we receive from the IdP. This update passes this data through
the SDK.
* Updates the SDK to 0.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants