fix: use augmented PATH for all git commands in GitWorktreeMainService#107
Merged
amandal0903 merged 2 commits intomainfrom Apr 11, 2026
Merged
fix: use augmented PATH for all git commands in GitWorktreeMainService#107amandal0903 merged 2 commits intomainfrom
amandal0903 merged 2 commits intomainfrom
Conversation
When launched from DMG/Finder, process.env.PATH is minimal and
doesn't include /opt/homebrew/bin where git-lfs lives. Git LFS
filter failures cause "the remote end hung up unexpectedly" errors,
silently breaking getDiffStats and removeWorktree.
Introduce a static git() helper that routes every execFile('git',...)
call through augmentedEnv(), and wire ILogService into the service
so getDiffStats failures are logged to main.log instead of swallowed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
git()helper that wrapsexecFilewith the augmented PATH environment, ensuring git is found when the app is launched from DMG/Finder on macOS (not just foraddWorktreewhich was the only call using it before)execFile('git', ...)calls with the new helperILogServiceand log errors ingetDiffStatscatch block for easier debugging