Merged
Conversation
added 9 commits
March 30, 2026 16:13
Add a tree view in the SCM sidebar that displays workstream comments in two subsections: Offline (local review comments from disk) and Online (GitHub PR review threads fetched via GraphQL). The Online section prompts GitHub OAuth sign-in when unauthenticated, then shows threaded PR review comments grouped by file and line. Also adds getRemoteUrl to IGitWorktreeService for resolving GitHub repository context from git remotes.
…polish - Add 1-hour TTL cache to GitHubCommentsServiceImpl so tree view and send-to-Claude share cached data without re-fetching - Extend "Send Review Comments to Claude" action to include both offline and online (GitHub PR) comments in a unified picker - Picker items use basename:line with codicon icons, source tags (offline/online), and comment body on the detail line - Online comments not deleted after send (they live on GitHub) - Add loading spinner and async fetch for Online section in tree view - Refresh button clears caches and re-fetches with loading state - Tree view uses basename for file labels, unicode symbols for counts - Add clearCaches() to IGitHubCommentsService for cache-only reset
- Fix triple-click bug: _showSavedComments now only disposes widgets with saved comments, preserving unsaved edit-mode widgets that were being killed by getDocumentComments re-queries - Add hasSavedComment getter to WorkstreamCommentZoneWidget - Picker: include resolved online comments with $(check) icon and "resolved" tag, unselected by default - Picker order: offline → online unresolved → online resolved, sorted by creation time within each group - Tree view: sort online threads unresolved-first, resolved at bottom
…into imb-classic-linux-font
…into imb-classic-linux-font
amandal0903
commented
Mar 30, 2026
| import { IQuickInputService, IQuickPickItem } from '../../../../platform/quickinput/common/quickInput.js'; | ||
| import { IWorkstreamComment } from '../../../services/workstreamComments/common/workstreamCommentService.js'; | ||
| import { IGitHubCommentsService } from '../../../services/workstreamComments/common/githubCommentsService.js'; | ||
| import { IGitHubCommentsService, ResolveContextStatus } from '../../../services/workstreamComments/common/githubCommentsService.js'; |
amandal0903
added a commit
that referenced
this pull request
Apr 3, 2026
* added comment section on SCM * feat: add Comments panel to SCM sidebar with offline and online sections Add a tree view in the SCM sidebar that displays workstream comments in two subsections: Offline (local review comments from disk) and Online (GitHub PR review threads fetched via GraphQL). The Online section prompts GitHub OAuth sign-in when unauthenticated, then shows threaded PR review comments grouped by file and line. Also adds getRemoteUrl to IGitWorktreeService for resolving GitHub repository context from git remotes. * feat: unified send-to-Claude with online comments, TTL cache, and UI polish - Add 1-hour TTL cache to GitHubCommentsServiceImpl so tree view and send-to-Claude share cached data without re-fetching - Extend "Send Review Comments to Claude" action to include both offline and online (GitHub PR) comments in a unified picker - Picker items use basename:line with codicon icons, source tags (offline/online), and comment body on the detail line - Online comments not deleted after send (they live on GitHub) - Add loading spinner and async fetch for Online section in tree view - Refresh button clears caches and re-fetches with loading state - Tree view uses basename for file labels, unicode symbols for counts - Add clearCaches() to IGitHubCommentsService for cache-only reset * fix: preserve unsaved comment widgets, add resolved tags, sort by status - Fix triple-click bug: _showSavedComments now only disposes widgets with saved comments, preserving unsaved edit-mode widgets that were being killed by getDocumentComments re-queries - Add hasSavedComment getter to WorkstreamCommentZoneWidget - Picker: include resolved online comments with $(check) icon and "resolved" tag, unselected by default - Picker order: offline → online unresolved → online resolved, sorted by creation time within each group - Tree view: sort online threads unresolved-first, resolved at bottom * fix: remove redundant check icon from resolved picker items * adding imb classic fonts * fix - online PR fetch multi-repo system * fix: auto refresh online comments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Why
Test plan
bun testpasseswsCLI