Skip to content

chore: optimize virtual logs #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
pubuzhixing8 merged 2 commits into from
Dec 4, 2025
Merged

chore: optimize virtual logs #309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2624ad3
chore: optimize virtual logs
Xwatson Dec 4, 2025
df8d961
feat: add note
Xwatson Dec 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/bright-buses-wish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'slate-angular': patch
---

optimize virtual logs
26 changes: 13 additions & 13 deletions packages/src/components/editable/editable.component.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -670,10 +670,12 @@ export class SlateEditable implements OnInit, OnChanges, OnDestroy, AfterViewChe
if (localStorage.getItem(SLATE_DEBUG_KEY) === 'true') {
const diffTopRenderedIndexes = [];
const diffBottomRenderedIndexes = [];
let direction = '';
if (newVisibleIndexes[0] > oldVisibleIndexes[0]) {
const isMissingTop = newVisibleIndexes[0] > oldVisibleIndexes[0];
const isAddedTop = newVisibleIndexes[0] < oldVisibleIndexes[0];
const isMissingBottom = newVisibleIndexes[newVisibleIndexes.length - 1] > oldVisibleIndexes[oldVisibleIndexes.length - 1];
const isAddedBottom = newVisibleIndexes[newVisibleIndexes.length - 1] < oldVisibleIndexes[oldVisibleIndexes.length - 1];
if (isMissingTop || isMissingBottom) {
// 向下
direction = 'down';
for (let index = 0; index < oldVisibleIndexes.length; index++) {
const element = oldVisibleIndexes[index];
if (!newVisibleIndexes.includes(element)) {
Expand All @@ -690,9 +692,8 @@ export class SlateEditable implements OnInit, OnChanges, OnDestroy, AfterViewChe
break;
}
}
} else {
} else if (isAddedTop || isAddedBottom) {
// 向上
direction = 'up';
for (let index = 0; index < newVisibleIndexes.length; index++) {
const element = newVisibleIndexes[index];
if (!oldVisibleIndexes.includes(element)) {
Expand All @@ -712,18 +713,17 @@ export class SlateEditable implements OnInit, OnChanges, OnDestroy, AfterViewChe
}
console.log('oldVisibleIndexes:', oldVisibleIndexes);
console.log('newVisibleIndexes:', newVisibleIndexes);
const directionStr = direction === 'down' ? '+' : '-';
console.log(
'diffTopRenderedIndexes:',
directionStr,
isMissingTop ? '-' : isAddedTop ? '+' : '-',
diffTopRenderedIndexes,
diffTopRenderedIndexes.map(index => virtualView.heights[index])
diffTopRenderedIndexes.map(index => this.getBlockHeight(index, 0))
);
console.log(
'diffBottomRenderedIndexes:',
directionStr,
isMissingBottom ? '+' : isAddedBottom ? '-' : '+',
diffBottomRenderedIndexes,
diffBottomRenderedIndexes.map(index => virtualView.heights[index])
diffBottomRenderedIndexes.map(index => this.getBlockHeight(index, 0))
);
const needTop = virtualView.heights.slice(0, newVisibleIndexes[0]).reduce((acc, height) => acc + height, 0);
const needBottom = virtualView.heights
Expand All @@ -738,13 +738,13 @@ export class SlateEditable implements OnInit, OnChanges, OnDestroy, AfterViewChe
return false;
}

private getBlockHeight(index: number) {
private getBlockHeight(index: number, defaultHeight: number = VIRTUAL_SCROLL_DEFAULT_BLOCK_HEIGHT) {
const node = this.editor.children[index];
if (!node) {
return VIRTUAL_SCROLL_DEFAULT_BLOCK_HEIGHT;
return defaultHeight;
}
const key = AngularEditor.findKey(this.editor, node);
return this.measuredHeights.get(key.id) ?? VIRTUAL_SCROLL_DEFAULT_BLOCK_HEIGHT;
return this.measuredHeights.get(key.id) ?? defaultHeight;
}

private buildAccumulatedHeight(heights: number[]) {
Expand Down