fix(virtual): #WIK-19556 there is a blank space below the scroll when the page switches to widescreen #316
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
Xwatson
commented
Dec 10, 2025
Xwatson
commented
- 页面切换宽屏后滚动下方有空白
- 编辑器宽度继承外界容器
- 监听宽度与上次不同，清除缓存测算高度重新调用滚动计算一次
… the page switches to widescreen
| if (!this.virtualConfig?.enabled) { | ||
| return; | ||
| } | ||
| if (entries.length > 0 && entries[0].contentRect.width !== editorResizeObserverRectWidth) { |
Collaborator
There was a problem hiding this comment.
建议这里考虑初始调用问题，就是页面初始化后首先调用一次么
pubuzhixing8
approved these changes
Dec 10, 2025
| if (entries.length > 0 && entries[0].contentRect.width !== editorResizeObserverRectWidth) { | ||
| editorResizeObserverRectWidth = entries[0].contentRect.width; | ||
| this.measuredHeights.clear(); | ||
| this.doVirtualScroll(); |
Collaborator
There was a problem hiding this comment.
我的意思这里是不是不需要调用，外面 theia 会再触发？
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.