feat: improve world app siwe handling#324
Merged
paolodamico merged 2 commits intomainfrom Mar 27, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 8b3ce54300
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
andy-t-wang
approved these changes
Mar 27, 2026
This was referenced Apr 8, 2026
Merged
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We don't need a safe smart account for world app SIWE.
Note
Medium Risk
Changes the World App SIWE message construction to depend on
EoaSigner(EOA address) instead ofSafeSmartAccount, affecting authentication/signature flows and address selection.Overview
World App SIWE message creation now takes an
EoaSignerinstead of aSafeSmartAccount, and sets the messageaddressdirectly from the EOA signer (removing the smart-account dependency for this flow).Adds convenience accessors returning
BedrockAddress(SiweMessage::address()andEoaSigner::address()), and updates SIWE tests to construct/useEoaSignerand validate EOA-recoverable signatures for the World App backend flow.Written by Cursor Bugbot for commit 9469d70. This will update automatically on new commits. Configure here.