Skip to content

feat: improve world app siwe handling#324

Merged
paolodamico merged 2 commits intomainfrom
siwe-122
Mar 27, 2026
Merged

feat: improve world app siwe handling#324
paolodamico merged 2 commits intomainfrom
siwe-122

Conversation

@paolodamico
Copy link
Copy Markdown
Contributor

@paolodamico paolodamico commented Mar 27, 2026

We don't need a safe smart account for world app SIWE.


Note

Medium Risk
Changes the World App SIWE message construction to depend on EoaSigner (EOA address) instead of SafeSmartAccount, affecting authentication/signature flows and address selection.

Overview
World App SIWE message creation now takes an EoaSigner instead of a SafeSmartAccount, and sets the message address directly from the EOA signer (removing the smart-account dependency for this flow).

Adds convenience accessors returning BedrockAddress (SiweMessage::address() and EoaSigner::address()), and updates SIWE tests to construct/use EoaSigner and validate EOA-recoverable signatures for the World App backend flow.

Written by Cursor Bugbot for commit 9469d70. This will update automatically on new commits. Configure here.

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 8b3ce54300

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread bedrock/src/siwe/mod.rs Outdated
@paolodamico paolodamico merged commit eb9ec91 into main Mar 27, 2026
15 checks passed
@paolodamico paolodamico deleted the siwe-122 branch March 27, 2026 19:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants