feat: allow multiple authorized host options for SIWE#344
Merged
paolodamico merged 2 commits intomainfrom Apr 21, 2026
Merged
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 902ea607ac
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit d1aa14f. Configure here.
Guardiola31337
approved these changes
Apr 21, 2026
This was referenced Apr 21, 2026
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

SIWE apps may have multiple authorized domains. This allows handling the different options.
Note
Medium Risk
Touches SIWE host-authorization logic; incorrect matching could allow or block authentication for unintended domains. Scope is small but security-sensitive, so test coverage and edge cases (ports/schemes) matter.
Overview
SIWE message parsing now accepts multiple authorized URL options:
SiweMessage::from_str_with_accounttakesauthorized_urls: Vec<String>and selects anexpected_authorityby matching thequerying_urlhost/port against any provided authorized URL, rejecting if none match.Tests are updated to pass URL lists and add coverage for matching from a mixed list of authorized domains, and
Cargo.lockis refreshed (notablyrandandrustls-webpkiversion bumps).Reviewed by Cursor Bugbot for commit d1aa14f. Bugbot is set up for automated code reviews on this repo. Configure here.