feat: clean up meta for ERC-20 transfers#89
Merged
paolodamico merged 6 commits intomainfrom Aug 29, 2025
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR cleans up the ERC-20 transfer metadata by removing analytics-focused fields and simplifying the API parameters. The changes focus on removing optional analytics data from the transfer metadata while exposing transfer association as a parameter for World App to specify.
- Removes
TransferSourceenum from ERC-20 transfer metadata as analytics data should not be stored here - Simplifies
transaction_transferAPI by removingNetworkandrpcparameters since World App only supports World Chain - Exposes
transfer_associationparameter to allow World App to specify metadata values
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| test_smart_account_transfer.rs | Updates test to use simplified API without Network and RPC parameters |
| transaction/mod.rs | Removes Network and RPC parameters, adds transfer_association parameter to transaction_transfer |
| transaction/contracts/erc20.rs | Removes TransferSource enum, shifts TransferAssociation to first metadata byte |
| smart_account/transaction_4337.rs | Reorders parameters in sign_and_execute method signature |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
karankurbur
approved these changes
Aug 29, 2025
andy-t-wang
approved these changes
Aug 29, 2025
Merged
This was referenced Apr 9, 2026
Closed
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
TransferSourcefrom ERC-20 transfer meta. Following discussions, analytics (particularly optional ones) data should not go here.Networkparameter fromtransaction_transfer. World App only supports transfers on World Chain.transaction_transfersuch that World App can specify this metadata value.transaction_transfer. For the time being the selection of the RPC should be delegated to Bedrock, and Bedrock will have relevant logic for this. Right now, taking a default.Note: while technically breaking API changes are being introduced, this API is not yet in use.