Skip to content

feat: clean up meta for ERC-20 transfers#89

Merged
paolodamico merged 6 commits intomainfrom
pd/rm-meta
Aug 29, 2025
Merged

feat: clean up meta for ERC-20 transfers#89
paolodamico merged 6 commits intomainfrom
pd/rm-meta

Conversation

@paolodamico
Copy link
Copy Markdown
Contributor

@paolodamico paolodamico commented Aug 26, 2025

Changes

  • Remove TransferSource from ERC-20 transfer meta. Following discussions, analytics (particularly optional ones) data should not go here.
  • Remove Network parameter from transaction_transfer. World App only supports transfers on World Chain.
  • Expose transfer_association in transaction_transfer such that World App can specify this metadata value.
  • Removes rpc parameter from transaction_transfer. For the time being the selection of the RPC should be delegated to Bedrock, and Bedrock will have relevant logic for this. Right now, taking a default.

Note: while technically breaking API changes are being introduced, this API is not yet in use.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR cleans up the ERC-20 transfer metadata by removing analytics-focused fields and simplifying the API parameters. The changes focus on removing optional analytics data from the transfer metadata while exposing transfer association as a parameter for World App to specify.

  • Removes TransferSource enum from ERC-20 transfer metadata as analytics data should not be stored here
  • Simplifies transaction_transfer API by removing Network and rpc parameters since World App only supports World Chain
  • Exposes transfer_association parameter to allow World App to specify metadata values

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.

File Description
test_smart_account_transfer.rs Updates test to use simplified API without Network and RPC parameters
transaction/mod.rs Removes Network and RPC parameters, adds transfer_association parameter to transaction_transfer
transaction/contracts/erc20.rs Removes TransferSource enum, shifts TransferAssociation to first metadata byte
smart_account/transaction_4337.rs Reorders parameters in sign_and_execute method signature

Comment thread bedrock/src/transaction/contracts/erc20.rs Outdated
Comment thread bedrock/src/transaction/contracts/erc20.rs
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
cursor[bot]

This comment was marked as outdated.

@paolodamico paolodamico merged commit 080fbb7 into main Aug 29, 2025
14 checks passed
@paolodamico paolodamico deleted the pd/rm-meta branch August 29, 2025 15:48
@github-actions github-actions bot mentioned this pull request Sep 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants