Skip to content

feat: Adopt protocol types and tweak bridge protocol#158

Merged
Takaros999 merged 4 commits into
mainfrom
takis/bump-protocol-versions
Mar 6, 2026
Merged

feat: Adopt protocol types and tweak bridge protocol#158
Takaros999 merged 4 commits into
mainfrom
takis/bump-protocol-versions

Conversation

@Takaros999
Copy link
Copy Markdown
Contributor

@Takaros999 Takaros999 commented Mar 6, 2026

This PR does 3 things:

  1. Bumps world-id-primitves to 0.5.0
  2. Adopts ProofRequest and `ProofResponse from protocol repo
  3. Updates the bridge protocol based on feedback from @paolodamico
    • Kept the proof request and response same as protocol types, and moved legacy parameters/responses separately to remain consistent
// before - bridge payload
{
    "proof_request": {
        "allow_legacy_proofs": true,
        ...
    }
}

// before - bridge payload
{

    "allow_legacy_proofs": true,
    // matches world-id-protocol types
    "proof_request": { 
        ...
    }
}

Note: Most of the diff comes from Cargo.lock

@vercel
Copy link
Copy Markdown

vercel Bot commented Mar 6, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
idkit-js-example Ready Ready Preview, Comment Mar 6, 2026 4:33am

Request Review

@socket-security
Copy link
Copy Markdown

socket-security Bot commented Mar 6, 2026

Warning

Review the following alerts detected in dependencies.

According to your organization's Security Policy, it is recommended to resolve "Warn" alerts. Learn more about Socket for GitHub.

Action Severity Alert  (click "▶" to expand/collapse)
Warn High
License policy violation: cargo sha3-asm under GPL-1.0+

License: GPL-1.0+ - the applicable license policy does not allow this license (4) (sha3-asm-0.1.5/cryptogams/arm/poly1305-armv4.pl)

License: GPL-1.0+ - the applicable license policy does not allow this license (4) (sha3-asm-0.1.5/cryptogams/mips/poly1305-mips.pl)

License: GPL-1.0+ - the applicable license policy does not allow this license (4) (sha3-asm-0.1.5/cryptogams/arm/poly1305-armv8.pl)

License: GPL-1.0+ - the applicable license policy does not allow this license (4) (sha3-asm-0.1.5/cryptogams/arm/sha512-armv8.pl)

License: GPL-1.0+ - the applicable license policy does not allow this license (4) (sha3-asm-0.1.5/cryptogams/arm/ghashv8-armx.pl)

From: ?cargo/alloy-primitives@1.5.7cargo/alloy-primitives@0.8.26cargo/sha3-asm@0.1.5

ℹ Read more on: This package | This alert | What is a license policy violation?

Next steps: Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support@socket.dev.

Suggestion: Find a package that does not violate your license policy or adjust your policy to allow this package's license.

Mark the package as acceptable risk. To ignore this alert only in this pull request, reply with the comment @SocketSecurity ignore cargo/sha3-asm@0.1.5. You can also ignore all packages with @SocketSecurity ignore-all. To ignore an alert for all future pull requests, use Socket's Dashboard to change the triage state of this alert.

View full report

@Takaros999 Takaros999 marked this pull request as ready for review March 6, 2026 04:31
@Takaros999
Copy link
Copy Markdown
Contributor Author

@codex review

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0b71de753

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread rust/core/src/bridge.rs
@Takaros999 Takaros999 merged commit 0240db5 into main Mar 6, 2026
14 checks passed
@Takaros999 Takaros999 deleted the takis/bump-protocol-versions branch March 6, 2026 05:44
This was referenced Mar 11, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants