fix: Fix error handling in native transport#177
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
| } | ||
|
|
||
| async pollOnce(): Promise<Status> { | ||
| if (this.resolved && this.resolvedResult) { |
There was a problem hiding this comment.
the main problem was here. we didn't handle the error case
|
|
||
| app.post("/api/rp-signature", (req, res) => { | ||
| const { ttl } = req.body; | ||
| const { ttl, action } = req.body; |
There was a problem hiding this comment.
this was forgotten, took the chance to fix
|
@codex review |
Takaros999
requested review from
Gr1dlock,
Guardiola31337,
SeanROlszewski,
andy-t-wang,
murph and
paolodamico
as code owners
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7afb4b046f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 33ca5ce71f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
2 participants
Summary
This PR fixes an issue with error handling in the native transport (Mini App context). The problem was that we didn't handle the error in the
.pollOncefunction.I took the chance to refactor the way we handle the in-flight promise:
resolvewithIDKitCompletionResulttype.complete()entrypointthis.resolved, this.settled, this.cancelledBefore
IDkit.before.fix.mp4
After
Fix.error.handling.in.mini.app.context.mp4