fix: bundle ESM-only @noble deps in CJS output#197
Merged
Conversation
…_ESM @noble/secp256k1 v2+ is intentionally ESM-only. Consumers using CJS (e.g. bundlers outputting CommonJS) hit ERR_REQUIRE_ESM when our CJS build leaves it as an external require(). Use tsup noExternal to inline these deps at build time.
Takaros999
requested review from
Gr1dlock,
Guardiola31337,
SeanROlszewski,
andy-t-wang,
murph and
paolodamico
as code owners
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 3998150796
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Gr1dlock
approved these changes
Apr 2, 2026
This was referenced Apr 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
@noble/secp256k1v2+ is intentionally ESM-only (ref). Our CJS build left it as an externalrequire(), causingERR_REQUIRE_ESMfor consumers whose bundlers output CommonJS.noExternaltoidkit-server's tsup config to inline@noble/secp256k1and@noble/hashesat build time.Test plan
require('@worldcoin/idkit-core')without error