Skip to content

Add response validation and inclusion proof caching#228

Merged
Dzejkop merged 2 commits intomainfrom
dzejkop/add-response-validation-and-inclusion-proof-caching
Feb 20, 2026
Merged

Add response validation and inclusion proof caching#228
Dzejkop merged 2 commits intomainfrom
dzejkop/add-response-validation-and-inclusion-proof-caching

Conversation

@Dzejkop
Copy link
Contributor

@Dzejkop Dzejkop commented Feb 20, 2026

No description provided.

@Dzejkop Dzejkop merged commit 61a8262 into main Feb 20, 2026
15 checks passed
@Dzejkop Dzejkop deleted the dzejkop/add-response-validation-and-inclusion-proof-caching branch February 20, 2026 14:14
@github-actions github-actions bot mentioned this pull request Feb 20, 2026
agentotto bot pushed a commit that referenced this pull request Mar 18, 2026
…en_mutex

The upstream thread-safety fix for sqlite3mc_cipher_name (issue #228) was
committed to sqlite3mc main in 07a1a60 on 2026-03-18, five days after the
v2.3.1 release. Rather than waiting for the next release, pin the build
directly to the fix commit via GitHub's /archive/<sha>.zip URL.

build.rs changes:
- Replace the release-zip URL with the commit-SHA source archive URL
  (https://github.com/utelle/SQLite3MultipleCiphers/archive/07a1a60...zip)
- SHA-256: 014d49636fea11fd598089f0ee4d19f022edc3aead0c769156444618eba6f051
- Extract the full source tree from the archive (stripping the GitHub-added
  top-level prefix directory)
- Run the bundled scripts/amalgamate.py to generate sqlite3mc_amalgamation.c
  and sqlite3mc_amalgamation.h before compiling (python3 required at build time)
- SQLite version bundled at this commit: 3.51.3

ffi.rs changes:
- Remove open_mutex() and its OnceLock/Mutex imports
- Restore sqlite3_open_v2 to a direct unsafe call (no Rust-side serialization)

The upstream fix replaces the sqlite3mcConfigureFromUri → sqlite3mc_cipher_name
call path (which wrote to a static char[] buffer shared across threads) with a
new sqlite3mcFindCipherName helper that returns a stable pointer into
globalCodecDescriptorTable memory — making concurrent opens race-free without
any Rust-side locking.

Upstream issue: utelle/SQLite3MultipleCiphers#228
Fix commit:     utelle/SQLite3MultipleCiphers@07a1a60
agentotto bot pushed a commit that referenced this pull request Mar 20, 2026
The thread-safety fix for sqlite3mc_cipher_name (upstream issue #228,
commit 07a1a60) has landed in the official v2.3.2 release (2026-03-19).

Switch build.rs from the raw GitHub commit-SHA source archive to the
official release amalgamation zip:

  URL:    https://github.com/utelle/SQLite3MultipleCiphers/releases/download/v2.3.2/sqlite3mc-2.3.2-sqlite-3.51.3-amalgamation.zip
  SHA256: 3462d3f09e91daa829b8787d93f451168fbafc4ccbf9d579f5e4117416f5c82d

The release zip ships sqlite3mc_amalgamation.c/.h pre-generated at the
archive root, so the amalgamate() helper and the Python 3 build-time
dependency are no longer needed and have been removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants