Forward-port PR #393 to main: split prove function for ffi

[Bisht13]

PR #393 was merged into the v1 branch but has not been ported to main.

• v1 PR: fix: split prove function for ffi #393
• Title: fix: split prove function for ffi
• Author: @ashpect
• Merged into v1: 2026-04-01

Context

Note that main already has the separate ffi v2.0 PR #384 ("feat: provekit-ffi v2.0"), which is a different change. PR #393 is a follow-up on top of the v1 ffi v2.0 port (#388). Please assess whether the split-prove change still applies on top of main's ffi v2.0 and port whatever portion is still relevant.

Action

Open a PR against main with the equivalent change. If the change is no longer needed on main (already covered by #384), close this issue with a note.

[Bisht13]

Closing — PR #393's changes are already on main, fully covered by PR #384 (v2.0 FFI), which rewrote the FFI with an in-memory API as a design goal rather than patching the v1 temp-file path.

File-by-file check of #393's diff against current main:

#393 change	File on main	Status
Prove trait split into prove(input_map) / prove_with_toml(path) / prove_with_witness(witness)	provekit/prover/src/lib.rs:43-51	✅ all three present
CLI: .prove(path) → .prove_with_toml(path)	tooling/cli/src/cmd/prove.rs:57	✅
Benches: .prove → .prove_with_toml	tooling/provekit-bench/benches/bench.rs:33,55	✅
Compiler tests: .prove → .prove_with_toml	tooling/provekit-bench/tests/compiler.rs:91,273,326	✅
FFI pk_prove_toml: .prove → .prove_with_toml	tooling/provekit-ffi/src/ffi.rs:559	✅
FFI pk_prove_json: drop temp-TOML-file hack, use prove(input_map) directly	tooling/provekit-ffi/src/ffi.rs:599-646	✅ no COUNTER/tmp_dir/std::fs::write, calls prove(input_map) directly

main also goes further than #393: Prover::Mavros and the Prover enum dispatch implement all three methods, tooling/provekit-wasm/src/prover.rs:119 uses prove_with_witness, and tooling/bench-prove-warm uses prove_with_toml.

No leftover delta to port. Closing.