Noir complete passport program#115
Conversation
…m-which-does-signature-check-dg1
…m-which-does-signature-check-dg1
…m-which-does-signature-check-dg1
…m-which-does-signature-check-dg1
Blackbox range function (WIP)
…m-which-does-signature-check-dg1
…noir-program-which-does-signature-check-dg1 [WIP] Noir passport program + "native" Noir SHA-256 impl
RyanCao7
changed the title
recmo
left a comment
recmo
left a comment
There was a problem hiding this comment.
It looks like there is some debug code committed. It's a large PR that ideally should be split into several smaller ones, but we can forgive this still.
There was a problem hiding this comment.
What is this file for? It seems redudant with r1cs.rs ?
There was a problem hiding this comment.
This file was accidentally re-added during the merge; file is now removed.
recmo
left a comment
recmo
left a comment
There was a problem hiding this comment.
What are the noir-r1cs/noir-passport-examples and noir-r1cs/test_programs folders for?
They contain a lot of generated data (including /target folders) that maybe should not be committed?
Otherwise LGTM!
| ); | ||
|
|
||
| // Check that the ID is not expired. | ||
| check_expiry(dg1, current_date.as_bytes()); |
There was a problem hiding this comment.
This is in principle also part of passport validity. (So I guess DG1 contents should be part of PassportValidityContents).
But let's not worry about that to much right now. It's more than good enough for an example.
Noir complete passport program
3 participants
Age check for Noir US-based passport program
noir-examples/noir-passport-examples/complete-age-check/noir-examples/noir-passport-examples/noir-native-sha256cargo test --release complete_age_check.Note
verify_msg_block()functions, but I'm not sure about the ones in the NoirBigNumlibrary.