Skip to content

Add more profiling tools#134

Merged
Bisht13 merged 7 commits into
mainfrom
piohei/profiling
Sep 3, 2025
Merged

Add more profiling tools#134
Bisht13 merged 7 commits into
mainfrom
piohei/profiling

Conversation

@piohei
Copy link
Copy Markdown
Collaborator

@piohei piohei commented Jul 22, 2025

This PR adds integration with tracy tools as well as information about using other profiling tools.

For e2e-testing to pass I needed to introduce new binary name with -profiled suffix. Now tests are running without profiling enabled by default.

@Bisht13 Bisht13 requested a review from Copilot August 22, 2025 10:24
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds profiling capabilities to the noir-r1cs project by integrating Tracy profiling tools and providing documentation for various profiling options. The changes enable performance analysis while maintaining backward compatibility for e2e tests.

  • Adds Tracy profiling integration with a new noir-r1cs-profiled binary
  • Refactors memory allocator to support shared state between profiled and non-profiled binaries
  • Provides comprehensive documentation for multiple profiling tools (Tracy, samply, instruments)

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.

Show a summary per file
File Description
noir-r1cs/src/cli/main_profiled.rs New binary entry point with Tracy profiling enabled
noir-r1cs/src/cli/main.rs Simplified main binary without profiling overhead
noir-r1cs/src/cli/measuring_alloc.rs Refactored allocator to separate state from implementation
noir-r1cs/src/cli/span_stats.rs Updated to use new allocator state reference
noir-r1cs/Cargo.toml Added profiled binary and Tracy dependencies
Cargo.toml Added Tracy workspace dependencies
README.md Added comprehensive profiling documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Comment thread README.md
Comment thread README.md
Comment thread noir-r1cs/src/cli/main_profiled.rs
@worldfnd worldfnd deleted a comment from codspeed-hq Bot Sep 3, 2025
@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Sep 3, 2025

CodSpeed WallTime Performance Report

Merging #134 will not alter performance

Comparing piohei/profiling (1a0c336) with main (b0f12f9)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

✅ 35 untouched benchmarks

@Bisht13 Bisht13 merged commit 6da2acb into main Sep 3, 2025
4 of 5 checks passed
@Bisht13 Bisht13 deleted the piohei/profiling branch September 3, 2025 17:17
dcbuild3r pushed a commit that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants