Add more profiling tools#134
Conversation
8e45e24 to
a8c94f7
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR adds profiling capabilities to the noir-r1cs project by integrating Tracy profiling tools and providing documentation for various profiling options. The changes enable performance analysis while maintaining backward compatibility for e2e tests.
- Adds Tracy profiling integration with a new
noir-r1cs-profiledbinary - Refactors memory allocator to support shared state between profiled and non-profiled binaries
- Provides comprehensive documentation for multiple profiling tools (Tracy, samply, instruments)
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| noir-r1cs/src/cli/main_profiled.rs | New binary entry point with Tracy profiling enabled |
| noir-r1cs/src/cli/main.rs | Simplified main binary without profiling overhead |
| noir-r1cs/src/cli/measuring_alloc.rs | Refactored allocator to separate state from implementation |
| noir-r1cs/src/cli/span_stats.rs | Updated to use new allocator state reference |
| noir-r1cs/Cargo.toml | Added profiled binary and Tracy dependencies |
| Cargo.toml | Added Tracy workspace dependencies |
| README.md | Added comprehensive profiling documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
a8c94f7 to
559a940
Compare
CodSpeed WallTime Performance ReportMerging #134 will not alter performanceComparing
|
This PR adds integration with tracy tools as well as information about using other profiling tools.
For e2e-testing to pass I needed to introduce new binary name with
-profiledsuffix. Now tests are running without profiling enabled by default.