Spark Progress#136
Merged
Merged
Conversation
batmendbar
requested review from
recmo,
veljkovranic and
wzmuda
and removed request for
wzmuda
kustosz
reviewed
Jul 25, 2025
Collaborator
kustosz
left a comment
kustosz
left a comment
There was a problem hiding this comment.
I haven't yet reviewed the cryptography, but code-wise this looks good. One request would be to fix the occurences of snake_case in .go files
| } | ||
|
|
||
| initialSumcheckData, lastEval, initialSumcheckFoldingRandomness, err := initialSumcheck(api, circuit, arthur, uapi, sc) | ||
| spartan_sumcheck_rand, spartan_sumcheck_last_value, err := runSumcheck(api, arthur, frontend.Variable(0), circuit.LogNumConstraints, 4) |
| return pk, vk, nil | ||
| } | ||
|
|
||
| func runSumcheck( |
Collaborator
There was a problem hiding this comment.
runSumcheck probably does not belong in mtUtilities
Collaborator
Author
There was a problem hiding this comment.
Got it, should we move it to mt.go?
veljkovranic
approved these changes
Jul 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is progress on implementing SPARK (as described in Section 7 of the Spartan paper), which provides a succinct commitment to a sparse matrix.
What has been done:
Implemented SPARK commitments and sumcheck
Modularized the circuit to support multiple WHIR proofs