Add ZK to WHIR and Spartan#138
Merged
Merged
Conversation
CodSpeed WallTime Performance ReportMerging #138 will degrade performances by 98.66%Comparing
|
| Benchmark | BASE |
HEAD |
Change | |
|---|---|---|---|---|
| ❌ | prove_poseidon_1000 |
6.2 s | 15.6 s | -60.55% |
| ❌ | prove_poseidon_1000_with_io |
7.8 s | 17.4 s | -55.1% |
| ❌ | verify_poseidon_1000 |
1.6 ms | 118.2 ms | -98.66% |
batmendbar
reviewed
Aug 20, 2025
batmendbar
reviewed
Aug 20, 2025
batmendbar
reviewed
Aug 20, 2025
cichaczem
approved these changes
Aug 26, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces two old PRs, is based on the main branch (which contains the first partial SPARK code) and uses this WHIR version: WizardOfMenlo/whir#188
The logic of ZKing follows Yogeshes descriptions from here: https://github.com/worldfnd/ProveKit/blob/make_spartan_zk/sage/fri-and-friends/Zero%20Knowledge%20for%20WHIR.md
Important note: End-to-end workflow is no longer doing the whole work of recursive verifier. The proper testing of it will be coming in this PR: 2821314