Skip to content

Add ZK to WHIR and Spartan#138

Merged
veljkovranic merged 34 commits into
mainfrom
make_spartan_zk
Aug 26, 2025
Merged

Add ZK to WHIR and Spartan#138
veljkovranic merged 34 commits into
mainfrom
make_spartan_zk

Conversation

@veljkovranic
Copy link
Copy Markdown
Collaborator

@veljkovranic veljkovranic commented Aug 6, 2025

Replaces two old PRs, is based on the main branch (which contains the first partial SPARK code) and uses this WHIR version: WizardOfMenlo/whir#188

The logic of ZKing follows Yogeshes descriptions from here: https://github.com/worldfnd/ProveKit/blob/make_spartan_zk/sage/fri-and-friends/Zero%20Knowledge%20for%20WHIR.md

Important note: End-to-end workflow is no longer doing the whole work of recursive verifier. The proper testing of it will be coming in this PR: 2821314

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Aug 20, 2025

CodSpeed WallTime Performance Report

Merging #138 will degrade performances by 98.66%

Comparing make_spartan_zk (9980f50) with main (6f0e6e4)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

❌ 3 regressions
✅ 32 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark BASE HEAD Change
prove_poseidon_1000 6.2 s 15.6 s -60.55%
prove_poseidon_1000_with_io 7.8 s 17.4 s -55.1%
verify_poseidon_1000 1.6 ms 118.2 ms -98.66%

Comment thread noir-r1cs/src/whir_r1cs.rs Outdated
Comment thread noir-r1cs/src/utils/zk_utils.rs Outdated
Comment thread noir-r1cs/src/utils/zk_utils.rs Outdated
@veljkovranic veljkovranic merged commit 490264f into main Aug 26, 2025
5 checks passed
@veljkovranic veljkovranic deleted the make_spartan_zk branch August 26, 2025 14:08
dcbuild3r pushed a commit that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants