Skip to content

Remove SPARK and add back direct matrix evaluation#141

Merged
veljkovranic merged 4 commits into
mainfrom
move-spark
Aug 18, 2025
Merged

Remove SPARK and add back direct matrix evaluation#141
veljkovranic merged 4 commits into
mainfrom
move-spark

Conversation

@batmendbar
Copy link
Copy Markdown
Collaborator

No description provided.

@batmendbar batmendbar changed the base branch from main to make_spartan_zk August 18, 2025 09:17
Copy link
Copy Markdown
Collaborator

@veljkovranic veljkovranic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@batmendbar batmendbar changed the base branch from make_spartan_zk to main August 18, 2025 09:38
@shreyas-londhe
Copy link
Copy Markdown
Collaborator

@batmendbar Can you make sure CI passes. We can merge then.

@codspeed-hq
Copy link
Copy Markdown

codspeed-hq Bot commented Aug 18, 2025

CodSpeed WallTime Performance Report

Merging #141 will improve performances by ×4.4

Comparing move-spark (165e2f3) with main (19c3141)

⚠️ Unknown Walltime execution environment detected

Using the Walltime instrument on standard Hosted Runners will lead to inconsistent data.

For the most accurate results, we recommend using CodSpeed Macro Runners: bare-metal machines fine-tuned for performance measurement consistency.

Summary

⚡ 3 improvements
✅ 32 untouched benchmarks

Benchmarks breakdown

Benchmark BASE HEAD Change
prove_poseidon_1000 26.9 s 6.1 s ×4.4
prove_poseidon_1000_with_io 28.6 s 7.8 s ×3.7
verify_poseidon_1000 3.2 ms 1.6 ms +99.96%

@veljkovranic veljkovranic merged commit 19973e0 into main Aug 18, 2025
5 checks passed
@veljkovranic veljkovranic deleted the move-spark branch August 18, 2025 13:04
@ashpect
Copy link
Copy Markdown
Collaborator

ashpect commented Aug 19, 2025

@veljkovranic Just curious, was there an unresolved blocker that required commenting out the compiler tests to keep CI passing ?

dcbuild3r pushed a commit that referenced this pull request May 16, 2026
Remove SPARK and add back direct matrix evaluation
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants