Skip to content

Calculate from transcript#20

Merged
batmendbar merged 4 commits into
mainfrom
calculate-from-transcript
Apr 21, 2025
Merged

Calculate from transcript#20
batmendbar merged 4 commits into
mainfrom
calculate-from-transcript

Conversation

@batmendbar
Copy link
Copy Markdown
Collaborator

This draft PR removes r, alpha, last_sumcheck_val, and statement from WhirR1CSProof. Now, verifier computes them on their own. whir_query_answer_sums remains in the WhirR1CSProof as the verifier cannot compute them from the transcript on their own.

@batmendbar batmendbar requested a review from recmo April 15, 2025 07:05
Copy link
Copy Markdown
Contributor

@recmo recmo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, should be a big improvement. @Dzejkop can you help out with perf and style review?

Comment thread noir-r1cs/src/whir_r1cs.rs Outdated
Comment thread noir-r1cs/src/whir_r1cs.rs Outdated
@batmendbar batmendbar requested a review from recmo April 16, 2025 00:08
@batmendbar batmendbar merged commit af05d26 into main Apr 21, 2025
0 of 2 checks passed
@batmendbar batmendbar deleted the calculate-from-transcript branch April 28, 2025 01:47
dcbuild3r pushed a commit that referenced this pull request May 16, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants